Skip to content

[release-1.5] CORS: clarify API documentation and remove conformance tests for credentialed requests#4699

Open
snorwin wants to merge 3 commits intokubernetes-sigs:release-1.5from
snorwin:update-cors-backport
Open

[release-1.5] CORS: clarify API documentation and remove conformance tests for credentialed requests#4699
snorwin wants to merge 3 commits intokubernetes-sigs:release-1.5from
snorwin:update-cors-backport

Conversation

@snorwin
Copy link
Copy Markdown
Member

@snorwin snorwin commented Mar 20, 2026

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:
Manual backport of #4663.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

Clarified CORS API documentation to describe behavior based on `allowCredentials` instead of credentialed requests.

snorwin added 3 commits March 20, 2026 09:00
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
…I reference

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snorwin
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2026
@youngnick
Copy link
Copy Markdown
Contributor

Since v1.5.1 has been released, this would imply we would need a v1.5.2?

@snorwin
Copy link
Copy Markdown
Member Author

snorwin commented Mar 21, 2026

@youngnick since this is purely a documentation change, I’m not sure it justifies a 1.5.2 release. I’ve backported it so that if we do ship another patch release, it will be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants