Skip to content

Add well-known labels package for GEP-1762#4705

Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
carmal891:4621-well-known-labels
Apr 8, 2026
Merged

Add well-known labels package for GEP-1762#4705
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
carmal891:4621-well-known-labels

Conversation

@carmal891
Copy link
Copy Markdown
Member

@carmal891 carmal891 commented Mar 21, 2026

What type of PR is this?

/kind gep

What this PR does / why we need it:
Introduces a well-known labels package in apis/v1 and uses it in conformance tests

Which issue(s) this PR fixes:

Fixes #4621

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 21, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 21, 2026

Hi @carmal891. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2026
snorwin
snorwin suggested changes Mar 21, 2026
View reviewed changes
Comment thread apis/v1/well_known_labels.go Outdated
@carmal891 carmal891 requested a review from snorwin March 21, 2026 08:18
@carmal891 carmal891 force-pushed the 4621-well-known-labels branch from 2749ead to d557233 Compare March 21, 2026 08:32
@youngnick
Copy link
Copy Markdown
Contributor

youngnick commented Mar 21, 2026

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2026
@carmal891 carmal891 mentioned this pull request Mar 22, 2026
Closed
11 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@carmal891 carmal891 force-pushed the 4621-well-known-labels branch from d557233 to 8ebc49d Compare April 1, 2026 21:21
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2026
@carmal891
Copy link
Copy Markdown
Member Author

carmal891 commented Apr 1, 2026

@youngnick I have rebased the PR. Kindly have a look

snorwin
snorwin suggested changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@snorwin snorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmal891 thank you, I just added some nits.

Comment thread apis/v1/well_known_labels.go Outdated
Comment thread apis/v1/well_known_labels.go Outdated
@snorwin
Copy link
Copy Markdown
Member

snorwin commented Apr 2, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
@carmal891 carmal891 requested a review from snorwin April 5, 2026 12:50
rikatz
rikatz reviewed Apr 6, 2026
View reviewed changes
Comment thread apis/v1/well_known_labels.go Outdated
@rikatz
Copy link
Copy Markdown
Member

rikatz commented Apr 6, 2026

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 6, 2026
@carmal891 carmal891 force-pushed the 4621-well-known-labels branch from b49c9e8 to b23ec22 Compare April 8, 2026 18:26
@carmal891 carmal891 requested a review from rikatz April 8, 2026 18:30
@carmal891
Copy link
Copy Markdown
Member Author

carmal891 commented Apr 8, 2026

@rikatz @snorwin Apologies for the delay as I got tied up with some urgent work commitments

snorwin
snorwin reviewed Apr 8, 2026
View reviewed changes
Comment thread apis/v1/well_known_labels.go Outdated
Comment thread apis/v1/well_known_labels.go Outdated
snorwin
snorwin approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@snorwin snorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmal891 thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carmal891, snorwin, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bfa026a into kubernetes-sigs:main Apr 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youngnick youngnick Awaiting requested review from youngnick

@rikatz rikatz Awaiting requested review from rikatz

1 more reviewer

@snorwin snorwin snorwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@snorwin snorwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define well-known labels and annotations package

5 participants

@carmal891 @k8s-ci-robot @youngnick @snorwin @rikatz