conformance: update tests to use gatewayv1 APIs#4722
conformance: update tests to use gatewayv1 APIs#4722k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
|
@cnvergence: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @cnvergence. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
UDPRoute is not promoted yet, so this PR is not valid |
|
hey @rikatz, even if it is just touching gateway? |
|
hum yes, I see it now, sorry my misunderstanding. I can see a bunch of other conformance tests are still using old v1beta1 (see ReferenceGrant which was also promoted), base/manifests.yaml and others, can you please make the changes on every other files that are still relying on the old API? Thanks |
|
No problem, we can do that, I will update the description as well :) |
snorwin
left a comment
There was a problem hiding this comment.
@cnvergence great catch, there are a few more places in the conformance test manifests that still use v1beta1 of Gateway. Can you align them as well?
|
/ok-to-test /cc @snorwin |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnvergence, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cnvergence can you please rebase? Thanks! |
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
e98c734 to
75e07ec
Compare
|
/retest |
|
/lgtm |
During reviewing UDPRoute, I have noticed that conformance tests are still on v1beta1 version.
This PR updates the resources apiVersion from v1beta1 to v1 in the conformance suite.
The Gateway resource has been GA since the Gateway API v1.0 release (October 2023) and should use gateway.networking.k8s.io/v1. The UDPRoute resource in the same file is intentionally left at v1alpha2, as it has not yet been promoted.
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: