Skip to content

conformance: update tests to use gatewayv1 APIs#4722

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
cnvergence:update-udp-test
Apr 7, 2026
Merged

conformance: update tests to use gatewayv1 APIs#4722
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
cnvergence:update-udp-test

Conversation

@cnvergence
Copy link
Copy Markdown
Member

@cnvergence cnvergence commented Apr 2, 2026

During reviewing UDPRoute, I have noticed that conformance tests are still on v1beta1 version.
This PR updates the resources apiVersion from v1beta1 to v1 in the conformance suite.

The Gateway resource has been GA since the Gateway API v1.0 release (October 2023) and should use gateway.networking.k8s.io/v1. The UDPRoute resource in the same file is intentionally left at v1alpha2, as it has not yet been promoted.

What type of PR is this?

/area conformance-test
What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Update Gateway version to v1 in UDP conformance test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@cnvergence: The label(s) kind/conformance-test cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

/kind conformance-test
What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Update Gateway version to v1 in UDP conformance test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 2, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @cnvergence. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2026
@cnvergence cnvergence mentioned this pull request Apr 2, 2026
@rikatz
Copy link
Copy Markdown
Member

rikatz commented Apr 2, 2026

UDPRoute is not promoted yet, so this PR is not valid

@cnvergence
Copy link
Copy Markdown
Member Author

hey @rikatz, even if it is just touching gateway?

@rikatz
Copy link
Copy Markdown
Member

rikatz commented Apr 2, 2026

hum yes, I see it now, sorry my misunderstanding.

I can see a bunch of other conformance tests are still using old v1beta1 (see ReferenceGrant which was also promoted), base/manifests.yaml and others, can you please make the changes on every other files that are still relying on the old API?

Thanks

@cnvergence
Copy link
Copy Markdown
Member Author

No problem, we can do that, I will update the description as well :)

Copy link
Copy Markdown
Member

@snorwin snorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnvergence great catch, there are a few more places in the conformance test manifests that still use v1beta1 of Gateway. Can you align them as well?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2026
@cnvergence cnvergence changed the title update Gateway version to v1 in UDP conformance test conformance: update tests to use gatewayv1 APIs Apr 3, 2026
@rikatz
Copy link
Copy Markdown
Member

rikatz commented Apr 3, 2026

/ok-to-test
/approve

/cc @snorwin
for lgtm

@k8s-ci-robot k8s-ci-robot requested a review from snorwin April 3, 2026 21:01
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cnvergence, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 3, 2026
@rikatz
Copy link
Copy Markdown
Member

rikatz commented Apr 7, 2026

@cnvergence can you please rebase?

Thanks!

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2026
@cnvergence
Copy link
Copy Markdown
Member Author

/retest

@rikatz
Copy link
Copy Markdown
Member

rikatz commented Apr 7, 2026

/lgtm
thanks @cnvergence

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit 6176b0f into kubernetes-sigs:main Apr 7, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants