-
Notifications
You must be signed in to change notification settings - Fork 462
frontend: PortForward: Add custom local port input dialog for port forwarding #4125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rwarding Signed-off-by: jaehanbyun <awbrg789@naver.com>
8271bd2 to
cfcaab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a user-facing dialog for port forwarding configuration, allowing users to specify custom local ports when starting port forwards in Docker Desktop environments. The key changes include:
- Added a new
PortForwardStartDialogcomponent for user port input with validation - Exported Docker Desktop port range constants (
DOCKER_DESKTOP_MIN_PORT,DOCKER_DESKTOP_MAX_PORT) for reuse - Modified port forwarding logic to only auto-assign ports when the user doesn't specify one
- Added translation strings for new dialog UI elements across multiple locales
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/portforward/PortForwardStartDialog.tsx | New dialog component for port input with Docker Desktop range validation |
| frontend/src/components/portforward/index.tsx | Integrated dialog into port forward list UI, replaced immediate start with dialog-based confirmation |
| frontend/src/components/common/Resource/PortForward.tsx | Exported port range constants, refactored port assignment logic to support user input, integrated dialog into resource view |
| frontend/src/i18n/locales/*/translation.json | Added translation keys for dialog UI (en with values, others empty) |
| frontend/src/plugin/snapshots/pluginLib.snapshot | Updated snapshot to include exported port constants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Ah, the example video didn’t include the custom port setup. I’ll upload an updated version. |
I've updated the video. |
illume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, jaehanbyun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
This PR adds a custom local port selection dialog for port forwarding, allowing users to specify their preferred local ports (e.g., 8080) instead of only using auto-assigned ports.
Related Issue
N/A
Changes
PortForwardStartDialogcomponent for custom port inputPortForward.tsxto integrate the dialog with existing port forward flowindex.tsx(port forwarding list) to use the dialog for Start actionSteps to Test
Screenshots (if applicable)
Screen.Recording.2025-11-08.at.10.41.28.PM.mov
Notes for the Reviewer