Skip to content

Commit 034cdba

Browse files
committed
removed unused import, initialized variable, updated log
1 parent bcf2ee6 commit 034cdba

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

inference_perf/metrics/prometheus_client.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# limitations under the License.
1414
import time
1515
from typing import cast
16-
from urllib.error import HTTPError
1716
import requests
1817
from inference_perf.client.base import ModelServerMetrics, ModelServerPrometheusMetric
1918
from inference_perf.config import PrometheusClientConfig
@@ -142,11 +141,14 @@ def collect_model_server_metrics(self, runtime_parameters: PerfRuntimeParameters
142141
for summary_metric_name in metrics_metadata:
143142
summary_metric_metadata = metrics_metadata.get(summary_metric_name)
144143
if summary_metric_metadata is None:
145-
print("Metric metadata is not present for metric: %s" % (summary_metric_name))
144+
print("Metric metadata is not present for metric: %s. Skipping this metric." % (summary_metric_name))
146145
continue
147146
summary_metric_metadata = cast(ModelServerPrometheusMetric, summary_metric_metadata)
148147
if summary_metric_metadata is None:
149-
print("Metric metadata is not present for metric: %s" % (summary_metric_name))
148+
print(
149+
"Metric metadata for %s is missing or has an incorrect format. Skipping this metric."
150+
% (summary_metric_name)
151+
)
150152
continue
151153

152154
query_builder = PrometheusQueryBuilder(summary_metric_metadata, duration)

inference_perf/reportgen/mock_reportgen.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
class MockReportGenerator(ReportGenerator):
2020
def __init__(self, metrics_client: MetricsClient | None) -> None:
2121
super().__init__(metrics_client=metrics_client)
22-
self.metrics_client = metrics_client
2322

2423
async def generate_report(self, runtime_parameters: PerfRuntimeParameters) -> None:
2524
print("\n\nGenerating Report ..")

0 commit comments

Comments
 (0)