-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: KIND Style Guide #4027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: KIND Style Guide #4027
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @adambkaplan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adding a style guide for contributors. The following text branding for the project is now official: - `kind` in backticks - "KIND" in all uppercase. Other prior forms, such as "KinD", are no longer allowed. Assisted-by: Cursor Signed-off-by: Adam Kaplan <adam@adambkaplan.com>
443a7c4 to
d78b3ee
Compare
| - "KIND" in all uppercase. | ||
|
|
||
| Using "kind" without backticks, "Kind" with only one uppercase, or "KinD" with leading and trailing | ||
| uppercase is not permitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are always exceptions, so "discouraged" might be a better choice than "not permitted". But not that critical.
|
Pointed out one minor nit, but I don't feel strongly about it. /lgtm |
Adding a style guide for contributors. The following text branding for the project is now official:
kindin backticksOther prior forms, such as "KinD", are no longer allowed.