kro cli publish command #655
Open
+358
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Sep 3, 2025
There was a problem hiding this comment.
@DhairyaMajmudar Can we have a seperate go.mod file for the CLI? looks like our dependencies are growing with each command that we're adding
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
a-hilaly
reviewed
Sep 14, 2025
Comment on lines
20
to
22
| generate "github.com/kro-run/kro/cmd/kro/commands/generate" | ||
| publish "github.com/kro-run/kro/cmd/kro/commands/publish" | ||
| validate "github.com/kro-run/kro/cmd/kro/commands/validate" |
Comment on lines
+90
to
+98
| if publishConfig.password == "" { | ||
| fmt.Print("Password: ") | ||
| bytePassword, err := term.ReadPassword(int(os.Stdin.Fd())) | ||
| fmt.Println() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to read password: %w", err) | ||
| } | ||
| publishConfig.password = string(bytePassword) | ||
| } |
There was a problem hiding this comment.
Users have to pass the password each time they need to publish their files?
| publishConfig.password = string(bytePassword) | ||
| } | ||
|
|
||
| ctx := context.Background() |
There was a problem hiding this comment.
nit: context not used yet.
also let's have a timeout context instead?
Comment on lines
+123
to
+156
| tempDir, err := os.MkdirTemp("", "kro-publish-*") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create temp dir: %w", err) | ||
| } | ||
| defer func() { | ||
| if err := os.RemoveAll(tempDir); err != nil { | ||
| fmt.Println("Warning: failed to remove temp dir", tempDir, ":", err) | ||
| } | ||
| }() | ||
|
|
||
| fmt.Println("Extracting", publishConfig.ociTarballPath, "to", tempDir, "...") | ||
| if err := untar(publishConfig.ociTarballPath, tempDir); err != nil { | ||
| return fmt.Errorf("failed to extract OCI tarball: %w", err) | ||
| } | ||
|
|
||
| store, err := oci.New(tempDir) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to open OCI layout at %s: %w", tempDir, err) | ||
| } | ||
|
|
||
| rootDesc, err := findRootManifestDescriptor(tempDir) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to find root manifest in OCI layout: %w", err) | ||
| } | ||
| fmt.Println("Found manifest to push:", rootDesc.Digest) | ||
|
|
||
| fmt.Println("Publishing to", publishConfig.remoteRef, "...") | ||
| _, err = oras.Copy(ctx, store, rootDesc.Digest.String(), repo, publishConfig.remoteRef, oras.DefaultCopyOptions) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to publish OCI image: %w", err) | ||
| } | ||
|
|
||
| fmt.Println("Successfully published OCI image to", publishConfig.remoteRef) | ||
| return nil |
There was a problem hiding this comment.
I think we're missing the kro package command, i wouldn't expect kro publish to do any package/extracting here. It should just get a tarball file and sent it to OCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new kro cli publish command is useful to publish an OCI image into container registries like docker hub, aws, gcr, etc....
Usage
kro package -f [FILE] -r [REGISTRY_URL] -u [USER_NAME] -p [PASSWORD]Flags:
Note: If username or password is not provided via flags the cli will prompt the user to provide them in further steps.
Demo
kro-publish.webm