feat: implement non-blocking CRD reconciliation with requeue support #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
a-hilaly
added
the
do-not-merge/hold
Implement non blocking CRD reconciliation to improve controller throughput when managing large amount of RGDs. The main idea is to free the workers to do other tasks when we're waiting for the establishement. Previously, the controller would block waiting for CRDs to become established, preventing other ResourceGraphDefinitions from being processed. This change introduces a requeue based approach where: - CRD creation happens immediately without blocking - controller checks CRD establishment status on each reconciliation - if CRD exists but isn't established, reconciler requeues after 500ms - other RGDs can be processed while waiting for CRD establishment this patch also gets rid of the CRDWraper abstraction layer as it's no longer needed.
a-hilaly
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement non blocking CRD reconciliation to improve controller throughput
when managing large amount of RGDs. The main idea is to free the workers to do
other tasks when we're waiting for the establishement.
Previously, the controller would block waiting for CRDs to become established,
preventing other ResourceGraphDefinitions from being processed. This change
introduces a requeue based approach where:
this patch also gets rid of the CRDWraper abstraction layer as it's no longer
needed.