Fix: apiVersion Cilium template

[uchiha-vivek]

What type of PR is this?

/kind bug

What this PR does / why we need it:
uses stable cilium.io/v2 API for Cilium BGP v2 templates
Cilium BGP v2 APIs (CiliumBGPClusterConfig, CiliumBGPPeerConfig, CiliumBGPNodeConfigOverride, CiliumBGPAdvertisement) graduated to the stable cilium.io/v2 API in Cilium v1.16+.
Using the alpha API results in deprecation warnings on newer Cilium versions.

Testes the updated cilium-bgp-cluster-config.yml.j2 template locally using Ansible and validated the manifest with yaml.safe_load

Which issue(s) this PR fixes:

Fixes #12819

Special notes for your reviewer:
This is something to similar to issue #12843 and I have raised one pr for that specific fix #12952

Does this PR introduce a user-facing change?:

This Pull Request fixes user facing YAML rendering issues in the Cilium BGP advertisement template and updates it to use the stable v2 API. The change ensures valid manifests are generated for configurations with nested selectors and removes deprecation warnings on newer Cilium versions. No breaking changes are introduced.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: uchiha-vivek
Once this PR has been reviewed and has the lgtm label, please assign tico88612 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @uchiha-vivek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[uchiha-vivek]

https://docs.cilium.io/en/stable/network/bgp-control-plane/bgp-control-plane-configuration/#bgp-cluster-configuration

I have taken the above link as reference

CiliumBGPClusterConfig

Their official docs

apiVersion: cilium.io/v2
kind: CiliumBGPClusterConfig
metadata:
  name: cilium-bgp
spec:
  nodeSelector:
    matchLabels:
      rack: rack0
  bgpInstances:
  - name: "instance-65000"
    localASN: 65000
    localPort: 179
    peers:
    - name: "peer-65000-tor1"
      peerASN: 65000
      peerAddress: fd00:10:0:0::1
      peerConfigRef:
        name: "cilium-peer"
    - name: "peer-65000-tor2"
      peerASN: 65000
      peerAddress: fd00:11:0:0::1
      peerConfigRef:
        name: "cilium-peer"

We can check the api version clearly

[tico88612]

You can consider to migrate to #12952.

[uchiha-vivek]

Member

Yes sir

[uchiha-vivek]

You can consider to migrate to #12952.

@tico88612 Sir
I have migrated the changes for #12952 into #12966

[tico88612]

/retitle Fix: apiVersion Cilium template
/ok-to-test

[tico88612]

Wondering why this part needs to be changed?

[uchiha-vivek]

Honestly indent(2) and indent(4) both works. It's not a significant change. I was just following Jinja Template Documentation

@tico88612 Sir i can safely revert it back.

[tico88612]

If you want to change it, please make your commit messages clearer, and the same goes for everything else.

[tico88612]

Superseded by #13095

/close

[k8s-ci-robot]

@tico88612: Closed this PR.

Details

In response to this:

Superseded by #13095

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.