-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: Support outputting stringData
from secretGenerator
#5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Support outputting stringData
from secretGenerator
#5894
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
14da6ae
to
905d18d
Compare
stringData
from secretGeneratorstringData
from secretGenerator
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matheuscscp, stealthybox The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows users to pass
stringData: true
to the secretGenerator, alongside thetype
option.When enabled, UTF-8 strings are output in plainText stringData, and non-UTF strings and any binary data fallback to the default behavior of being base64 encoded in
data
.This is very similar to the default, kyaml behavior of loading values into ConfigMap's
data
andbinaryData
fields.This feature provides a general U/X improvement for people using kustomize interactively, and also allows Flux users to template into generated secrets.
(Flux users already can and do template into ConfigMaps, so we want to give people more secure mechanisms in kustomize-controller)
resolves #5142 #1444 #1261