WIP: Turn clusterName:string into a type parameter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
mjudeikis
approved these changes
Feb 12, 2025
embik
reviewed
Feb 13, 2025
| // and managing the lifecycle of each cluster, calling `Engage` on the manager | ||
| // it is run against whenever a new cluster is discovered and cancelling the | ||
| // context used on engage when a cluster is unregistered. | ||
| // | ||
| // Example: A Cluster API provider would be responsible for discovering and | ||
| // managing clusters that are backed by Cluster API resources, which can live | ||
| // in multiple namespaces in a single management cluster. | ||
| type Provider interface { | ||
| type TypedProvider[cluster comparable] interface { |
There was a problem hiding this comment.
Nit: Should this generic maybe be called something else, since cluster seems confusing? Something like clusterIdentifier?
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.