Skip to content

Feat integrate spiffe #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Feat integrate spiffe #1434

wants to merge 6 commits into from

Conversation

AhmedGrati
Copy link

POC of #1186.

@TessaIO
feat: add signature to CRDs created by nfd-worker
b0290ef 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@TessaIO
add signing and verifying crds
eeecf02 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit ef2093a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6541464369b15500083ccaff
😎 Deploy Preview https://deploy-preview-1434--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2023
@AhmedGrati
Copy link
Author

FYI @marquiz.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TessaIO
chore: add helm and kustomize deployments of spiffe
e8748c8 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2023
@AhmedGrati AhmedGrati force-pushed the feat-integrate-spiffe branch 2 times, most recently from deb947b to da71ef4 Compare October 29, 2023 16:02
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 29, 2023
@AhmedGrati AhmedGrati force-pushed the feat-integrate-spiffe branch 2 times, most recently from 34f56b0 to a37590b Compare October 29, 2023 16:55
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2023
@AhmedGrati AhmedGrati force-pushed the feat-integrate-spiffe branch from a37590b to 42a3b9f Compare October 29, 2023 19:14
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 29, 2023
@TessaIO
chore: make spiffe optional
7f2b4a7 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@AhmedGrati AhmedGrati force-pushed the feat-integrate-spiffe branch from 42a3b9f to 7f2b4a7 Compare October 29, 2023 22:59
@TessaIO
chore: adjust the spiffe utils and make it testable
b4317ec 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@TessaIO
test: add unit-tests for spiffe utils
ef2093a 
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@TessaIO
Copy link
Member

TessaIO commented Mar 4, 2024

@AhmedGrati Design doc approved, let's push this forward

Hey @ArangoGutierrez, This is my new account as @AhmedGrati was locked out! Sure, I will return to work on this once #1592 is merged.

@ArangoGutierrez
Copy link
Contributor

@AhmedGrati Design doc approved, let's push this forward

Hey @ArangoGutierrez, This is my new account as @AhmedGrati was locked out! Sure, I will return to work on this once #1592 is merged.

What did you do to get locked out of your account :P jajajaj . been there no worries. after pushing really hard you get someone on the line, don't loose faith

@TessaIO
Copy link
Member

TessaIO commented Mar 11, 2024

What did you do to get locked out of your account :P jajajaj . been there no worries. after pushing really hard you get someone on the line, don't loose faith

basically lost everything, recovery codes, mfa device, and ssh keys. GitHub support said that they can't validate my identity cryptographically, so no way...

@ArangoGutierrez
Copy link
Contributor

What did you do to get locked out of your account :P jajajaj . been there no worries. after pushing really hard you get someone on the line, don't loose faith

basically lost everything, recovery codes, mfa device, and ssh keys. GitHub support said that they can't validate my identity cryptographically, so no way...

Damm man, sad to hear that. :(

@ArangoGutierrez
Copy link
Contributor

Since this comes from a KEP, we will have feature gates flags moving forward #1623

@ArangoGutierrez
Copy link
Contributor

@TessaIO should we re-create this PR with your new GitHub account?

@TessaIO
Copy link
Member

TessaIO commented Apr 2, 2024

@TessaIO should we re-create this PR with your new GitHub account?

Yes @ArangoGutierrez. As soon as my current PRs are merged, I'll proceed to this one!

@ArangoGutierrez ArangoGutierrez mentioned this pull request Apr 15, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2024
@TessaIO
Copy link
Member

TessaIO commented Jul 1, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 1, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2024
@TessaIO
Copy link
Member

TessaIO commented Sep 30, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 28, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AhmedGrati
Once this PR has been reviewed and has the lgtm label, please ask for approval from marquiz. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TessaIO
Copy link
Member

TessaIO commented Feb 27, 2025

@ArangoGutierrez I don't think that we need this draft anymore.

@marquiz
Copy link
Contributor

marquiz commented Mar 3, 2025

superseded by #1663
/close

@k8s-ci-robot
Copy link
Contributor

@marquiz: Closed this PR.

In response to this:

superseded by #1663
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

@marquiz marquiz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AhmedGrati @k8s-ci-robot @ArangoGutierrez @k8s-triage-robot @marquiz @TessaIO