Skip to content

feat: allow to override kubeNetwork #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Jasstkn
Copy link
Contributor

@Jasstkn Jasstkn commented May 7, 2024

Hi!

I would like to add support for changing kubeNetwork name. It covers the scenario where the CNI of choice is not Calico. The default value ensures that this change is not breaking.

Verification

$ helm template kube-proxy-windows . --set cni.kubeNetwork=azure --set --set cni.WinOverlay=false | kubectl apply -f -

$ kubectl get pods -n kube-system | grep kube-proxy-windows
kube-proxy-windows-c9hd4                    1/1     Running   0              14h
kube-proxy-windows-jb55q                    1/1     Running   0              14h
kube-proxy-windows-xlprg                    1/1     Running   0              14h

$ kubectl logs -f kube-proxy-windows-jb55q  -n kube-system
...
I0507 07:15:09.702772    6944 hns.go:312] "Queried load balancers" count=18
I0507 07:15:09.702772    6944 proxier.go:1242] "Syncing Policies"
I0507 07:15:09.702772    6944 proxier.go:1177] "Syncing proxy rules complete" elapsed="13.8497ms"
I0507 07:15:09.702772    6944 proxier.go:1177] "Syncing proxy rules complete" elapsed="13.7926ms"
I0507 07:15:09.702772    6944 bounded_frequency_runner.go:296] sync-runner: ran, next possible in 1s, periodic in 30s
I0507 07:15:09.702772    6944 bounded_frequency_runner.go:296] sync-runner: ran, next possible in 1s, periodic in 30s

Signed-off-by: Mariia Kotliarevskaia <mariia.kotliarevskaia@gmail.com>
@k8s-ci-robot k8s-ci-robot requested review from jayunit100 and knabben May 7, 2024 07:18
Copy link

linux-foundation-easycla bot commented May 7, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @Jasstkn!

It looks like this is your first PR to kubernetes-sigs/windows-service-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/windows-service-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jasstkn, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@jsturtevant
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit dc37317 into kubernetes-sigs:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants