Address the comments

Author: zylxjtu

.github/workflows/helm-chart-validation.yaml

@@ -0,0 +1,72 @@
+# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
+
+name: helm-chart-validation
+
+on:
+  push:
+    branches: [main, master]
+    paths:
+      - helpers/helm/**
+      - helpers/hpc-mutating-webhook/**
+      - helpers/hyper-v-mutating-webhook/**
+  pull_request:
+    branches: [main, master] 
+    paths:
+      - helpers/helm/**
+      - helpers/hpc-mutating-webhook/**
+      - helpers/hyper-v-mutating-webhook/**
+      - .github/workflows/helm-chart-validation.yaml
+  workflow_dispatch:
+
+jobs:
+  validate-helm-chart:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        values-file: [values.yaml, values-hpc.yaml, values-hyperv.yaml]
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Install Helm
+        run: curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+
+      - name: Install kubeconform
+        run: |
+          wget -q https://github.com/yannh/kubeconform/releases/latest/download/kubeconform-linux-amd64.tar.gz
+          tar xf kubeconform-linux-amd64.tar.gz
+          sudo mv kubeconform /usr/local/bin
+
+      - name: Validate Chart with ${{ matrix.values-file }}
+        run: |
+          echo "🔍 Validating Helm chart with ${{ matrix.values-file }}"
+          
+          # Lint the chart
+          helm lint helpers/helm/
+          
+          # Render and validate against Kubernetes schemas
+          helm template test helpers/helm/ -f helpers/helm/${{ matrix.values-file }} | kubeconform -summary -verbose
+          
+          echo "✅ Chart validation passed!"
+
+  build:
+    runs-on: ubuntu-latest
+    needs: validate-helm-chart
+    steps:
+      - uses: actions/checkout@v4
+      
+      - name: Build both webhook images
+        if: ${{ github.event_name != 'push' }}
+        run: |
+          echo "🔨 Building both HPC and Hyper-V webhook images..."
+          cd helpers
+          make docker-build-all
+          echo "✅ Both webhook images built successfully!"
+
+      - name: Build and push webhook images to registry
+        if: ${{ github.event_name == 'push' }}
+        run: |
+          echo "🚀 Building and pushing both webhook images to registry..."
+          echo "${{ secrets.DOCKER_SECRET }}" | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
+          cd helpers
+          make docker-push-all
+          echo "✅ Both webhook images built and pushed successfully!"

helpers/Makefile

@@ -20,8 +20,8 @@
 # Override: make docker-build-all REGISTRY=myregistry.io VERSION=2.0
 
 # Image registry and version (edit here or override on command line)
-REGISTRY ?= wcctpublic.azurecr.io/kubernetes-sigs/windows-testing
-VERSION ?= 10.0
+REGISTRY ?= sigwindowstools
+VERSION ?= latest
 
 # Constructed image names
 HYPERV_IMG = $(REGISTRY)/hyperv-webhook:$(VERSION)