Add the hpc webhook #533
Add the hpc webhook #533
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test all |
k8s-ci-robot
added
size/XXL
|
@zylxjtu: No jobs can be run with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-e2e-capz-windows-2022-extension |
|
@zylxjtu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
zylxjtu
force-pushed
the
master
branch
3 times, most recently
from
f67ca8b to
d4a8061
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Can we add a GH action that validates the helm charts? |
Added |
marosset
added
the
tide/merge-method-squash
marosset
left a comment
marosset
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold (feel free to release the hold whenever)
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, zylxjtu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
3 participants
As explained here, windows hpc container will need to do some tweaks on the commandline
But making os runtime dependent change in the common test framework will be difficult even impossible kubernetes/test/e2e/framework/registry/registry.go at master · kubernetes/kubernetes
The approach is to run a webhook under the hood to do the trick to manipulate the related command-line changes
Adding a webhook may also provide the cleanest mechanism to:
Avoid OS-specific logic in shared E2E test code
Preserve parity with Linux test behavior
Enable reuse for other Windows-specific scenarios