Skip to content

refact e2e test config enhancing setup, logging, steps and documenting hooks #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jul 18, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR introduce several updates in the e2e loadbalancer reachable e2e test cases targeting to:

  • enhance the e2e documentation on hooks utilization
  • encapsulating test case configuration/data into a single container
  • enhance ginkgo steps and framework logging

The main motivation of this PR is to increase the flexibility to add new test cases with customization without losing existing reachable test configuration. This is an isolated PR from broad/unrelated changes from #1214

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2025
@mtulio mtulio force-pushed the refact-e2e-loadbalancer branch from 1c7c035 to e6e2e06 Compare July 18, 2025 15:27
@mtulio
Copy link
Contributor Author

mtulio commented Jul 18, 2025

results of e2e tests locally:

$./e2e.test --ginkgo.v  --ginkgo.focus 'loadbalancer'
  W0718 10:49:13.164350  313350 test_context.go:478] Unable to find in-cluster config, using default host : https://127.0.0.1:6443
  Jul 18 10:49:13.164: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite: AWS Cloud Provider End-to-End Tests 
=========================================================================================
Random Seed: 1752846553 - will randomize all specs

Will run 5 of 8 specs
SS
------------------------------
[...]
------------------------------

Ran 4 of 8 Specs in 1194.446 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 4 Skipped
PASS

@mtulio mtulio marked this pull request as ready for review July 18, 2025 15:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Jul 18, 2025

Hi, this PR is ready for review. PTAL?

@k8s-ci-robot k8s-ci-robot requested review from dims and mmerkes July 18, 2025 15:29
@elmiko
Copy link

elmiko commented Jul 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2025
Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mostly makes sense to me, i just had a question about one of the refactoring choices you made. fwiw, it's not a blocker for me, i'm just curious.

This change enhance the logging and ginkgo steps of the loadbalancer
reachable e2e test cases.

The Hooks, created to allow test case customization, is renamed and documented.

Finally the configuration are encapsulated into a single structure to
enhance parallel tests.
@mtulio mtulio force-pushed the refact-e2e-loadbalancer branch from e6e2e06 to bcbb71f Compare July 18, 2025 17:19
@mtulio
Copy link
Contributor Author

mtulio commented Jul 18, 2025

looks like flag, re-testing:
/test pull-cloud-provider-aws-e2e-kubetest2

@mtulio
Copy link
Contributor Author

mtulio commented Jul 18, 2025

/assign @kmala @elmiko

@mtulio mtulio changed the title refact: e2e tests documenting hooks and enhance logging/steps refact e2e tests documenting hooks and enhance logging/steps Jul 18, 2025
@mtulio mtulio changed the title refact e2e tests documenting hooks and enhance logging/steps refact e2e test config enhancing setup, logging, steps and documenting hooks Jul 18, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Jul 22, 2025

This PR is ready for final review. Thanks @elmiko for feedback.

@elmiko
Copy link

elmiko commented Jul 22, 2025

this makes sense to me, thanks for adjusting the config function.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants