-
Notifications
You must be signed in to change notification settings - Fork 338
refact e2e test config enhancing setup, logging, steps and documenting hooks #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @mtulio. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1c7c035
to
e6e2e06
Compare
results of e2e tests locally: $./e2e.test --ginkgo.v --ginkgo.focus 'loadbalancer'
W0718 10:49:13.164350 313350 test_context.go:478] Unable to find in-cluster config, using default host : https://127.0.0.1:6443
Jul 18 10:49:13.164: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite: AWS Cloud Provider End-to-End Tests
=========================================================================================
Random Seed: 1752846553 - will randomize all specs
Will run 5 of 8 specs
SS
------------------------------
[...]
------------------------------
Ran 4 of 8 Specs in 1194.446 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 4 Skipped
PASS |
Hi, this PR is ready for review. PTAL? |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mostly makes sense to me, i just had a question about one of the refactoring choices you made. fwiw, it's not a blocker for me, i'm just curious.
This change enhance the logging and ginkgo steps of the loadbalancer reachable e2e test cases. The Hooks, created to allow test case customization, is renamed and documented. Finally the configuration are encapsulated into a single structure to enhance parallel tests.
e6e2e06
to
bcbb71f
Compare
looks like flag, re-testing: |
This PR is ready for final review. Thanks @elmiko for feedback. |
this makes sense to me, thanks for adjusting the config function. /lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR introduce several updates in the e2e loadbalancer reachable e2e test cases targeting to:
The main motivation of this PR is to increase the flexibility to add new test cases with customization without losing existing reachable test configuration. This is an isolated PR from broad/unrelated changes from #1214
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: