Skip to content

Commit 20b3c07

Browse files
committed
Addressed more comments
1 parent 2558823 commit 20b3c07

File tree

2 files changed

+9
-2
lines changed
  • keps/sig-scheduling

2 files changed

+9
-2
lines changed

keps/sig-scheduling/4815-dra-partitionable-devices/README.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -352,8 +352,9 @@ on the device that mirrors the node selector fields on the `ResourceSlice`.
352352
device can be allocated if the necessary counters (i.e. resources) is not
353353
available. Each counter is identified by its name and the name of its set.
354354
Nesting counters inside sets was chosen because it enables referencing a mixin
355-
(link to other KEP here) with a list of counters in different counter sets and it
356-
makes it possible to align groups of counters with the underlying physical devices.
355+
([KEP-5234](https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/5234-dra-resourceslice-mixins))
356+
with a list of counters in different counter sets and it makes it possible
357+
to align groups of counters with the underlying physical devices.
357358

358359
1. Introduce a new field, `ConsumesCounters` under `Device`. It specifies
359360
the amount the device will draw for the counters in the referenced `CounterSet`.

keps/sig-scheduling/5234-dra-resourceslice-mixins/README.md

+6
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,12 @@ During version skew where the apiserver supports the feature and the scheduler
595595
doesn't, the devices that is using the mixins feature will be dropped and
596596
not visible to the scheduler (ref [Implementation](#implementation)).
597597

598+
The exception here is in 1.34 (the first version where this feature is in alpha).
599+
If the APIServer is at 1.34 and the scheduler is at 1.33, the APIServer will send
600+
the new fields, but the scheduler will not know what to do about them. It will end
601+
up ignoring them, which can lead to incorrect scheduling decisions. Note that this
602+
scenario only applies to the initial 1.34 release and will not apply for 1.35+.
603+
598604
## Production Readiness Review Questionnaire
599605

600606
<!--

0 commit comments

Comments
 (0)