Skip to content

Redirect apt/yum.kubernetes.io to the deprecation announcement #6546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 7, 2024

@BenTheElder proposed redirecting apt.kubernetes.io and yum.kubernetes.io (the root paths, not any of subpaths) to the deprecation announcement. See https://kubernetes.slack.com/archives/C2C40FMNF/p1708988257580149?thread_ts=1708546638.738649&cid=C2C40FMNF

This PR implements this in a similar way as for pkgs.k8s.io (#6544).

/assign @upodroid @dims @ameukam @BenTheElder
/hold
to reach the consensus

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from aojea and thockin March 7, 2024 20:12
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 7, 2024
@ameukam
Copy link
Member

ameukam commented Mar 7, 2024

+1. I'll leave the LGTM to @BenTheElder.

@upodroid
Copy link
Member

upodroid commented Mar 7, 2024

+1

@xmudrii xmudrii closed this Mar 13, 2024
@xmudrii xmudrii deleted the apt-yum-deprecation-page branch March 13, 2024 20:24
@BenTheElder
Copy link
Member

Too late +1 :(
Sorry, I was out end of week

@xmudrii xmudrii restored the apt-yum-deprecation-page branch March 13, 2024 22:33
@xmudrii xmudrii reopened this Mar 13, 2024
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Mar 14, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9885773 into kubernetes:main Mar 14, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 14, 2024
@xmudrii xmudrii deleted the apt-yum-deprecation-page branch March 14, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants