Skip to content

GCP: add GKE nodepool for SIG node #8035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Apr 24, 2025

Related:

Setup a dedicated nodepool with taints using an external terraform module. We want evaluate running prowjobs on COS with newer machine types.

Related:
  - kubernetes#8004

Setup a dedicated nodepool with taints using an external terraform module.
We want evaluate running prowjobs on COS with newer machine types.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2025
@ameukam
Copy link
Member Author

ameukam commented Apr 24, 2025

/hold

@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ labels Apr 24, 2025
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2025
@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-infra-prow-build workspace: default

Show Output
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool will be created
+ resource "google_container_node_pool" "nodepool" {
      + cluster                     = (sensitive value)
      + id                          = (known after apply)
      + initial_node_count          = 1
      + instance_group_urls         = (known after apply)
      + location                    = (sensitive value)
      + managed_instance_group_urls = (known after apply)
      + max_pods_per_node           = (known after apply)
      + name                        = "sig-node-pool1"
      + name_prefix                 = (known after apply)
      + node_count                  = (known after apply)
      + node_locations              = (known after apply)
      + operation                   = (known after apply)
      + project                     = "k8s-infra-prow-build"
      + version                     = (known after apply)

      + autoscaling {
          + location_policy = (known after apply)
          + max_node_count  = 10
          + min_node_count  = 1
        }

      + management {
          + auto_repair  = true
          + auto_upgrade = true
        }

      + network_config (known after apply)

      + node_config {
          + disk_size_gb     = (known after apply)
          + disk_type        = "hyperdisk-balanced"
          + effective_taints = (known after apply)
          + image_type       = "COS_CONTAINERD"
          + labels           = (known after apply)
          + local_ssd_count  = (known after apply)
          + logging_variant  = (known after apply)
          + machine_type     = "n4-highmem-8"
          + metadata         = (known after apply)
          + min_cpu_platform = (known after apply)
          + oauth_scopes     = [
              + "https://www.googleapis.com/auth/cloud-platform",
            ]
          + preemptible      = false
          + service_account  = "gke-nodes-prow-build@k8s-infra-prow-build.iam.gserviceaccount.com"
          + spot             = false

          + confidential_nodes (known after apply)

          + gcfs_config (known after apply)

          + guest_accelerator (known after apply)

          + gvnic {
              + enabled = true
            }

          + kubelet_config (known after apply)

          + shielded_instance_config {
              + enable_integrity_monitoring = true
              + enable_secure_boot          = true
            }

          + taint {
              + effect = "NO_SCHEDULE"
              + key    = "dedicated"
              + value  = "sig-node"
            }

          + windows_node_config (known after apply)

          + workload_metadata_config {
              + mode = "GKE_METADATA"
            }
        }

      + upgrade_settings (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.
  • ▶️ To apply this plan, comment:
    atlantis apply -d infra/gcp/terraform/k8s-infra-prow-build
  • 🚮 To delete this plan and lock, click here
  • 🔁 To plan this project again, comment:
    atlantis plan -d infra/gcp/terraform/k8s-infra-prow-build

Plan: 1 to add, 0 to change, 0 to destroy.


  • ⏩ To apply all unapplied plans from this Pull Request, comment:
    atlantis apply
  • 🚮 To delete all plans and locks from this Pull Request, comment:
    atlantis unlock

@ameukam
Copy link
Member Author

ameukam commented Apr 24, 2025

atlantis apply

@k8s-infra-ci-robot
Copy link
Contributor

Ran Apply for dir: infra/gcp/terraform/k8s-infra-prow-build workspace: default

Show Output
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Creating...
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [10s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [20s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [30s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [40s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [50s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [1m0s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [1m10s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [1m20s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [1m30s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [1m40s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [1m50s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [2m0s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [2m10s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [2m20s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [2m30s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [2m40s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [2m50s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [3m0s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [3m10s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [3m20s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [3m30s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [3m40s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Still creating... [3m50s elapsed]
module.sig_node_node_pool_1_n4_highmem_8.google_container_node_pool.nodepool: Creation complete after 3m57s [id=projects/k8s-infra-prow-build/locations/us-central1/clusters/prow-build/nodePools/sig-node-pool1]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

@ameukam
Copy link
Member Author

ameukam commented Apr 24, 2025

/hold cancel
cc @dims @BenTheElder

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@BenTheElder
Copy link
Member

#8004 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 50882ed into kubernetes:main May 7, 2025
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 7, 2025
@k8s-infra-ci-robot
Copy link
Contributor

Warning: The plan for dir: infra/gcp/terraform/k8s-infra-prow-build workspace: default was discarded via the Atlantis UI.

To apply this plan you must run plan again.

ameukam added a commit to ameukam/test-infra that referenced this pull request May 14, 2025
Related to:
  - kubernetes/k8s.io#8004

Use tolerations to schedule e2e-containerd prowjobs to a dedicated
nodepool added in kubernetes/k8s.io#8035.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants