-
Notifications
You must be signed in to change notification settings - Fork 879
Creating a Mail List for Kubespray Notifications #8098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yankay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HI @fabriziopandini @neolit123 Would you please help to review it :-) |
@@ -480,6 +480,17 @@ groups: | |||
- dlipovetsky@d2iq.com | |||
- neolit123@gmail.com | |||
|
|||
- email-id: k8s-infra-staging-kubespray@kubernetes.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you assist the Kubespray team in establishing a notification mailing list for Kubespray-related communications?
in that case you might to scope and name the ML differently.
i'm proposing the name sig-cluster-lifecycle-kubespray
- email-id: k8s-infra-staging-kubespray@kubernetes.io | ||
name: k8s-infra-staging-kubespray | ||
description: |- | ||
ACL for staging kubespray artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put the correct description for purpose of the ML
description: |- | ||
ACL for staging kubespray artifacts. | ||
settings: | ||
ReconcileMembers: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set to false or automation will only allow the listed members below to ever join.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might also want to set all these params
settings: |
you can google search for what these google group params mean.
ReconcileMembers: "true" | ||
members: | ||
- kay.yan@daocloud.io | ||
- mg@max.gautier.name #VannTen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- mg@max.gautier.name #VannTen | |
- mg@max.gautier.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neolit123
Thank you very much for your detailed guidance. It has been modified.
b566b83
to
212f01f
Compare
WhoCanViewGroup: "ANYONE_CAN_VIEW" | ||
WhoCanPostMessage: "ANYONE_CAN_POST" | ||
WhoCanJoin: "ANYONE_CAN_JOIN" | ||
MessageModerationLevel: "MODERATE_ALL_MESSAGES" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this means you have approve all messages from members or they cannot be posted.
are you sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you might want to use the same settings as these for a general-purpose ML.
settings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neolit123
Thanks for your patient guidance. It has been changed.
212f01f
to
4f78c00
Compare
WhoCanModerateContent: "OWNERS_AND_MANAGERS" | ||
MembersCanPostAsTheGroup: "false" | ||
ReconcileMembers: "false" | ||
members: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
members: | |
owners: |
one final thing to change ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again, @neolit123. It has been changed.
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
4f78c00
to
b907fef
Compare
- email-id: sig-cluster-lifecycle-kubespray@kubernetes.io | ||
name: sig-cluster-lifecycle-kubespray | ||
description: |- | ||
Group for Kubespray maintainers to receive CI system notifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this is not what you had in the pr description?
there are different settings for groups that will only receive notifications and public groups that are for user conversations.
what is the actual purpose of this ML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent was for a private mailing list for the maintainers. What prompted that was missing a notification from the infra provider of our CI (Oracle Cloud Infrastructure) with a need for action, leading to unavailability of our CI cluster. (The notification was sent to a mail which appears to be cncf, probably the organization contact for project using CNCF credits ? Not sure). The notif system is configurable from their console.
I'm not sure how sensible we should consider the notifs, but we erred on the side of caution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, looks like i misunderstand and the OP did speak about notifications. sorry about that @yankay
in that case:
- please use exactly the same settings like
- email-id: sig-cluster-lifecycle-kubeadm-alerts@kubernetes.io - name the ML sig-cluster-lifecycle-kubespray-alerts
- add your owners
The Kubespray maintainers team requires a dedicated mailing list to serve as an official point of contact for receiving notifications from service providers (e.g., CI systems), ref to https://kubernetes.slack.com/archives/CDQSC941H/p1746458606052179?thread_ts=1746431573.418909&cid=CDQSC941H .
Could you assist the Kubespray team in establishing a notification mailing list for Kubespray-related communications?