Support tags for kubetest-kops #17682
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
hakman
approved these changes
Oct 16, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold On AWS, |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unlgtm |
hakman
reviewed
Oct 16, 2025
Comment on lines
197
to
199
| for _, tag := range d.Tags { | ||
| args = append(args, "--cloud-labels", tag) | ||
| } |
There was a problem hiding this comment.
Can you try this?
Suggested change
| for _, tag := range d.Tags { | |
| args = append(args, "--cloud-labels", tag) | |
| } | |
| args = append(args, "--cloud-labels", strings.Join(d.Tags, ",")) |
Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
ameukam
force-pushed
the
add-tags-support
branch
from
2824233 to
b392c42
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.