Skip to content

Commit 8d737c1

Browse files
committed
kubelet: enhance exec probe logging with pod and container context
Signed-off-by: xigang <wangxigang2014@gmail.com>
1 parent a6f32c0 commit 8d737c1

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

pkg/kubelet/prober/prober.go

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,11 @@ func (pb *prober) runProbe(ctx context.Context, probeType probeType, p *v1.Probe
152152
case p.Exec != nil:
153153
klog.V(4).InfoS("Exec-Probe runProbe", "pod", klog.KObj(pod), "containerName", container.Name, "execCommand", p.Exec.Command)
154154
command := kubecontainer.ExpandContainerCommandOnlyStatic(p.Exec.Command, container.Env)
155-
return pb.exec.Probe(pb.newExecInContainer(ctx, container, containerID, command, timeout))
155+
result, output, err := pb.exec.Probe(pb.newExecInContainer(ctx, container, containerID, command, timeout))
156+
if err != nil {
157+
klog.ErrorS(err, "Exec probe failed", "probeType", probeType, "pod", klog.KObj(pod), "containerName", container.Name, "command", command)
158+
}
159+
return result, output, err
156160

157161
case p.HTTPGet != nil:
158162
req, err := httpprobe.NewRequestForHTTPGetAction(p.HTTPGet, &container, status.PodIP, "probe")
@@ -169,7 +173,11 @@ func (pb *prober) runProbe(ctx context.Context, probeType probeType, p *v1.Probe
169173
headers := p.HTTPGet.HTTPHeaders
170174
klogV4.InfoS("HTTP-Probe", "scheme", scheme, "host", host, "port", port, "path", path, "timeout", timeout, "headers", headers, "probeType", probeType)
171175
}
172-
return pb.http.Probe(req, timeout)
176+
result, output, err := pb.http.Probe(req, timeout)
177+
if err != nil {
178+
klog.ErrorS(err, "HTTP probe failed", "probeType", probeType, "pod", klog.KObj(pod), "containerName", container.Name, "request", req)
179+
}
180+
return result, output, err
173181

174182
case p.TCPSocket != nil:
175183
port, err := probe.ResolveContainerPort(p.TCPSocket.Port, &container)
@@ -182,7 +190,11 @@ func (pb *prober) runProbe(ctx context.Context, probeType probeType, p *v1.Probe
182190
host = status.PodIP
183191
}
184192
klog.V(4).InfoS("TCP-Probe", "host", host, "port", port, "timeout", timeout)
185-
return pb.tcp.Probe(host, port, timeout)
193+
result, output, err := pb.tcp.Probe(host, port, timeout)
194+
if err != nil {
195+
klog.ErrorS(err, "TCP probe failed", "probeType", probeType, "pod", klog.KObj(pod), "containerName", container.Name, "host", host, "port", port, "timeout", timeout)
196+
}
197+
return result, output, err
186198

187199
case p.GRPC != nil:
188200
host := status.PodIP
@@ -191,7 +203,11 @@ func (pb *prober) runProbe(ctx context.Context, probeType probeType, p *v1.Probe
191203
service = *p.GRPC.Service
192204
}
193205
klog.V(4).InfoS("GRPC-Probe", "host", host, "service", service, "port", p.GRPC.Port, "timeout", timeout)
194-
return pb.grpc.Probe(host, service, int(p.GRPC.Port), timeout)
206+
result, output, err := pb.grpc.Probe(host, service, int(p.GRPC.Port), timeout)
207+
if err != nil {
208+
klog.ErrorS(err, "GRPC probe failed", "probeType", probeType, "pod", klog.KObj(pod), "containerName", container.Name, "host", host, "service", service, "port", p.GRPC.Port, "timeout", timeout)
209+
}
210+
return result, output, err
195211

196212
default:
197213
klog.V(4).InfoS("Failed to find probe builder for container", "containerName", container.Name)

0 commit comments

Comments
 (0)