Skip to content

Commit 2832241

Browse files
committed
reason: Make vment-helper error driver agnostic
Previously it was used only for vfkit, so we suggested to fallback to the `nat` network. This advice is not relevant to krunkit or to qemu (which can also use vmnet-helper). Change the error to recommend installing vment-helper. We need to think how we can recommend other networks for vfkit and qemu. Another solution is to create error for every driver+network combination but this seems hard to manage.
1 parent bc9bff7 commit 2832241

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

pkg/minikube/reason/reason.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -552,15 +552,11 @@ var (
552552
NotFoundVmnetHelper = Kind{
553553
ID: "NOT_FOUND_VMNET_HELPER",
554554
ExitCode: ExProgramNotFound,
555-
Advice: translate.T(`vmnet-helper was not found on the system, resolve by:
555+
Advice: translate.T(`vmnet-helper was not found on the system.
556556
557-
Option 1) Installing vmnet-helper:
557+
Please install vmnet-helper using these instrunctions:
558558
559-
https://github.com/nirs/vmnet-helper#installation
560-
561-
Option 2) Using the nat network:
562-
563-
minikube start{{.profile}} --driver vfkit --network nat`),
559+
https://github.com/nirs/vmnet-helper#installation`),
564560
Style: style.SeeNoEvil,
565561
}
566562
NotConfiguredVmnetHelper = Kind{

0 commit comments

Comments
 (0)