Skip to content

clean up duplicate code in multiple files #20828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
medyagh opened this issue May 24, 2025 · 3 comments
Open

clean up duplicate code in multiple files #20828

medyagh opened this issue May 24, 2025 · 3 comments
Assignees

Comments

@medyagh
Copy link
Member

medyagh commented May 24, 2025

          excellent work @LJTian thank you for fixing this up ! I look forward to see more contributions from you! one thing that I noiced the docker-env and podman-env files share a lot of code, that is opportunity for more refactor to make them reuse the code instead of duplocation...

Originally posted by @medyagh in #20804 (review)

@medyagh
Copy link
Member Author

medyagh commented May 24, 2025

@LJTian would you like to assign this for yourself ?

Another location we have duplicate code is in Vfkit Driver and Qemu Driver

@LJTian
Copy link
Contributor

LJTian commented May 24, 2025

/assign

@afbjorklund
Copy link
Collaborator

afbjorklund commented May 25, 2025

The podman-env command is deprecated, you could just remove it?

Everything is supposed to use either minikube image or docker-env


Both podman-env and vfkit was copy-and-paste jobs, from the originals...

One, Two, Many (1,2, n)

i.e. refactor on third

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants