Skip to content

vmnet: Support offloading for krunkit #20831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vmnet: Support offloading for krunkit #20831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions pkg/drivers/vmnet/vmnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ type Helper struct {
// will obtain the same MAC address from vmnet.
InterfaceID string

// Offloading is required for krunkit, doss not work with vfkit.
// We must use this until libkrun add support for disabling offloading:
// https://github.com/containers/libkrun/issues/264
Offloading bool

// Set when vmnet interface is started.
macAddress string
}
Expand Down Expand Up @@ -115,13 +120,18 @@ func ValidateHelper() error {
// machine. The helper will create a unix datagram socket at the specfied path.
// The client (e.g. vfkit) will connect to this socket.
func (h *Helper) Start(socketPath string) error {
cmd := exec.Command(
"sudo",
args := []string{
"--non-interactive",
executablePath,
"--socket", socketPath,
"--interface-id", h.InterfaceID,
)
}

if h.Offloading {
args = append(args, "--enable-tso", "--enable-checksum-offload")
}

cmd := exec.Command("sudo", args...)

// Create vmnet-helper in a new process group so it is not harmed when
// terminating the minikube process group.
Expand Down