Skip to content

Commit ee55d8d

Browse files
authored
Merge pull request #2766 from dipesh-rawat/enhancements-handbook-updates
Update Enhancements handbook with improvements based on retro items
2 parents 0be56c6 + 4511307 commit ee55d8d

File tree

1 file changed

+15
-0
lines changed
  • release-team/role-handbooks/enhancements

1 file changed

+15
-0
lines changed

release-team/role-handbooks/enhancements/README.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,18 @@ See the sig-architecture Enhancements [KEP Template](https://github.com/kubernet
299299
300300
**All** enhancements going into the release must have their pull requests in a merge-ready state with approved and lgtm labels applied. This includes tests, and docs PRs opened by the due date. Due to the Prow queue, this may mean that approved PRs merge shortly after the deadline.
301301
302+
To avoid delays and ensure everything is in place for Code Freeze:
303+
- **Coordinate with the Release Branch Manager**: Reach out to the Release Branch Manager to give them a heads-up about the upcoming Code Freeze. They are responsible for raising the PR that officially enforces the Code Freeze. Coordinating early helps minimize the risk of delays and last-minute blockers. For more details on their role and responsibilities, refer to the [Release Branch Manager Handbook](https://github.com/kubernetes/sig-release/blob/master/release-engineering/role-handbooks/branch-manager.md)
304+
305+
- **Ensure the Code Freeze PR is Ready to Merge**:
306+
The Code Freeze PR should be ready for merge (i.e., it has both `lgtm` and `approved` labels) **on or before the date of Code Freeze**.
307+
**Recommendation:** Work with the Release Branch Manager to get the PR created ahead of time and ensure all **required labels** (`lgtm`, `approved`) are in place. They can add a `/hold` to prevent the PR from merging early - then simply lift the hold in the Code Freeze Party.
308+
309+
- **Reference Code Freeze PRs**: Below are examples of PRs used to enforce Code Freeze in previous releases:
310+
- [PR Enforcing Code Freeze - v1.33](https://github.com/kubernetes/test-infra/pull/34532)
311+
- [PR Enforcing Code Freeze - v1.32](https://github.com/kubernetes/test-infra/pull/33778)
312+
- [PR Enforcing Code Freeze - v1.31](https://github.com/kubernetes/test-infra/pull/33049)
313+
302314
Read https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#code-freeze for more information on the Code Freeze.
303315
304316
#### Week of Code Freeze
@@ -433,6 +445,9 @@ Here's where this enhancement currently stands:
433445
For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):
434446
- { list of PRs associated with this enhancement }
435447

448+
If the implementation work for this enhancement is occurring **out-of-tree** (i.e., outside of [`k/k`](https://github.com/kubernetes/kubernetes)), please link the relevant PRs in the issue description for visiblity.
449+
Alternativelty, if you're unable to provide specific PR links, a confirmation that **all out-of-tree implementation work is complete and merged** will help us finalize tracking and maintain accuracy.
450+
436451
If you anticipate missing code freeze, you can file an [exception request](https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md) in advance.
437452

438453
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

0 commit comments

Comments
 (0)