-
Notifications
You must be signed in to change notification settings - Fork 412
Update release notes draft to version v1.34.0-alpha.3 #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release notes draft to version v1.34.0-alpha.3 #2816
Conversation
Signed-off-by: ArvindParekh <aruparekh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done
@Chewypewy: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best of 2023
@Chewypewy: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems like majority of alpha.3 were chore works to replacing deprecated package so not much comment on release notes from my side. And the maps and .md release note are still sync with each other (unless changing occur in maps later).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArvindParekh, wendy-ha18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also could you have a look in the lint check failed @ArvindParekh? one or a few .yaml files may not sastify the validation. |
cc @Vyom-Yadav for support the review and approval quickly. |
…ch the updated map files
@wendy-ha18 correct. Accordingly, many changes in this PR are simply changing single-quotes to backticks in those deprecated package messages, to basically better represent them during markdown. Some others are fixing tense and grammatical errors.
I did update the map files to fix the failing tests, and have updated the |
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.34.0-alpha.3
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is an automated PR generated from
krel The Kubernetes Release Toolbox