Restore ability to manually run 5k tests on PR #34546
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/L
| # Fork of ci-kubernetes-e2e-gce-scale-performance | ||
| - name: ci-kubernetes-e2e-gce-scale-performance-manual | ||
| cluster: k8s-infra-prow-build | ||
| always_run: false |
There was a problem hiding this comment.
Taken always_run, max_concurrency, branches from other optional presubmits like pull-kubernetes-kubemark-e2e-gce-scale
| base_ref: master | ||
| path_alias: k8s.io/perf-tests | ||
| annotations: | ||
| testgrid-dashboards: presubmits-kubernetes-scalability |
There was a problem hiding this comment.
Replaced annotations
| - master | ||
| - main | ||
| decorate: true | ||
| path_alias: k8s.io/kubernetes |
There was a problem hiding this comment.
Removed k8s.io/kubernetes from extra_refs and moved there as path_alias
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@serathius: Updated the
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - --env=KUBE_DNS_MEMORY_LIMIT=300Mi | ||
| - --extract=ci/fast/latest-fast | ||
| - --gcp-nodes=5000 | ||
| - --gcp-project-type=scalability-scale-project |
There was a problem hiding this comment.
There is only one of these. So running this can disrupt the periodics?
There was a problem hiding this comment.
There was a problem hiding this comment.
Possibly, however we don't want to increase capacity for 5k tests.
There was a problem hiding this comment.
Clarification Note: We use SIG K8s Infra managed projects now, but we still need GCP to approve quota on a project like this, and I'm also not sure if we want to either.
There was a problem hiding this comment.
I'm concerned about disrupting the release-informing periodics though.
There was a problem hiding this comment.
Was this different before removing the Job? The goal of manual scalability tests is to test high risk performance changes, like new etcd minor release. I expect we only have 1-2 features like this in release cycle.
There was a problem hiding this comment.
Was this different before removing the Job? The goal of manual scalability tests is to test high risk performance changes, like new etcd minor release. I expect we only have 1-2 features like this in release cycle.
- --gcp-project-type=scalability-presubmit-5k-project
I guess we had another pool for 5k scale presubmit?
There was a problem hiding this comment.
kubernetes/k8s.io#7929 for rolling-forward when we can
There was a problem hiding this comment.
/assign @wojtek-t @mborsz