Skip to content

GCB Docker GCloud: Update buildx to v0.19.3. #34751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Apr 29, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/images size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 29, 2025
@Gacko
Copy link
Member Author

Gacko commented Apr 29, 2025

/cc @BenTheElder @aojea

@BenTheElder
Copy link
Member

FWIW I strongly recommend leveraging GOTOOLCHAIN to control the version in your repo, which just requires 1.21+ in the image to bootstrap.

we won't be able to have the right default for everyone.

@Gacko
Copy link
Member Author

Gacko commented Apr 29, 2025

Well, the only reason I'm proposing this change is that I've seen Go and buildx being bumped regularly from different people in the past. As we from the Ingress NGINX project are using this image and regularly check for updates, I thought it might be a good idea to bump these dependencies to newer versions.

@BenTheElder
Copy link
Member

Well, the only reason I'm proposing this change is that I've seen Go and buildx being bumped regularly from different people in the past. As we from the Ingress NGINX project are using this image and regularly check for updates, I thought it might be a good idea to bump these dependencies to newer versions.

Sure, but usually when I see people doing this it's so their builds get a newer go version, and there's a much better way to do that where the version is controlled in the repo being built so upgrading is tested and so you can upgrade more quickly.

@Gacko
Copy link
Member Author

Gacko commented Apr 30, 2025

I'm not bumping Go for Ingress NGINX, no worries. I'm bumping it because I'm using this image and am interested in maintaining it and keeping it up-to-date.

If you have concerns about the bump, we can also just go for the latest v1.23 version!

Regarding buildx: I'll check the changelogs now.

@Gacko
Copy link
Member Author

Gacko commented Apr 30, 2025

Ok, well. I didn't go into details, but just from the v0.19.0 release notes it might be worth doing this step by step. They seem to introduce deprecations / changes step by step, so I'd suggest going to v0.19.3 in a first step, let people adapt and then move on in a few weeks, so we somewhen catch up with the latest version.

@Gacko Gacko changed the title GCB Docker GCloud: Update Go to v1.24.2 and buildx to v0.23.0. GCB Docker GCloud: Update Go to v1.23.8 and buildx to v0.19.3. Apr 30, 2025
@Gacko
Copy link
Member Author

Gacko commented May 5, 2025

Any last comments here, @BenTheElder? Shall we merge it as it is right now? Or shall I just leave it and close the PR?

@Gacko Gacko changed the title GCB Docker GCloud: Update Go to v1.23.8 and buildx to v0.19.3. GCB Docker GCloud: Update Go to v1.23.9 and buildx to v0.19.3. May 12, 2025
@Gacko
Copy link
Member Author

Gacko commented May 12, 2025

@BenTheElder I rebased the PR and updated Go to v1.23.9. Any chances to get it merged?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2025
@BenTheElder
Copy link
Member

/lgtm
/approve
Sorry, in the future if something gets stuck this long I think it's reasonable to tag in a second approver.
Recently a bit more crunched than usual

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2025
@Gacko Gacko changed the title GCB Docker GCloud: Update Go to v1.23.9 and buildx to v0.19.3. GCB Docker GCloud: Update buildx to v0.19.3. May 14, 2025
@Gacko
Copy link
Member Author

Gacko commented May 14, 2025

Well, someone else bumped Go to v1.24.3 on master in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants