-
Notifications
You must be signed in to change notification settings - Fork 2.7k
GCB Docker GCloud: Update buildx
to v0.19.3.
#34751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/cc @BenTheElder @aojea |
FWIW I strongly recommend leveraging GOTOOLCHAIN to control the version in your repo, which just requires 1.21+ in the image to bootstrap. we won't be able to have the right default for everyone. |
Well, the only reason I'm proposing this change is that I've seen Go and buildx being bumped regularly from different people in the past. As we from the Ingress NGINX project are using this image and regularly check for updates, I thought it might be a good idea to bump these dependencies to newer versions. |
Sure, but usually when I see people doing this it's so their builds get a newer go version, and there's a much better way to do that where the version is controlled in the repo being built so upgrading is tested and so you can upgrade more quickly. |
I'm not bumping Go for Ingress NGINX, no worries. I'm bumping it because I'm using this image and am interested in maintaining it and keeping it up-to-date. If you have concerns about the bump, we can also just go for the latest v1.23 version! Regarding |
Ok, well. I didn't go into details, but just from the v0.19.0 release notes it might be worth doing this step by step. They seem to introduce deprecations / changes step by step, so I'd suggest going to v0.19.3 in a first step, let people adapt and then move on in a few weeks, so we somewhen catch up with the latest version. |
buildx
to v0.23.0.buildx
to v0.19.3.
Any last comments here, @BenTheElder? Shall we merge it as it is right now? Or shall I just leave it and close the PR? |
buildx
to v0.19.3.buildx
to v0.19.3.
@BenTheElder I rebased the PR and updated Go to v1.23.9. Any chances to get it merged? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
buildx
to v0.19.3.buildx
to v0.19.3.
Well, someone else bumped Go to v1.24.3 on |
No description provided.