etcd: enable pull-etcd-verify for release-3.4 branch

[joshjms]

Enable pull-etcd-verify for release-3.4 branch.

No change is needed to emulate the behavior in Github Actions
Reference: #32754

/cc @ivanvc

[k8s-ci-robot]

Hi @joshjms. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshjms
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• config/jobs/etcd/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joshjms]

For the main branch, make verify has the following:

.PHONY: verify
verify: verify-gofmt verify-bom verify-lint verify-dep verify-shellcheck verify-goword \
	verify-govet verify-license-header verify-mod-tidy \
	verify-shellws verify-proto-annotations verify-genproto verify-yamllint \
	verify-govet-shadow verify-markdown-marker verify-go-versions

In release-3.4 however, a lot of these doesn't exist so.

.PHONY: verify
verify: verify-go-versions

I think we need to backport them to release-3.4 branch as well. What do you think @ivanvc ?

[ivanvc]

/hold

I think we need to backport them to release-3.4 branch as well. What do you think @ivanvc ?

Thanks for the pull request, @joshjms. Add all the verify checks in release-3.4 to the verify make target. I don't suggest backporting all of our verification checks, as they may not be relevant to that code base.

[ivanvc]

/ok-to-test

[ivanvc]

However, backporting the mod_tidy check would be a good idea. Ref: etcd-io/etcd#19872

[joshjms]

Okk will do