Skip to content

VPA: enable InPlaceOrRecreate feature gate in tests #34790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxcao13
Copy link
Member

Enables the InPlaceOrRecreate feature gate by default in all periodic and pre-submit VPA tests.

Signed-off-by: Max Cao <macao@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maxcao13
Copy link
Member Author

/cc @raywainman @omerap12 @adrianmoisey

There's no way to test this config before shipping it right?
Does anyone actually know if the env parameters propagate the envvars down to the our hack script that needs to use them?

Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2025
@omerap12
Copy link
Member

omerap12 commented May 13, 2025

/cc @raywainman @omerap12 @adrianmoisey

There's no way to test this config before shipping it right? Does anyone actually know if the env parameters propagate the envvars down to the our hack script that needs to use them?

hmmm I'm actually not sure about that.. but I see other projects that do the same thing so I guess it's ok - for example

- name: AZURE_STORAGE_DRIVER
value: "kubernetes.io/azure-file" # In-tree Azure file storage class
- name: TEST_MIGRATION
value: "true"
- name: NODE_MACHINE_TYPE # CAPZ config
value: "Standard_D2s_v3"
- name: DISABLE_ZONE # azurefile-csi-driver config
value: "true"
- name: KUBERNETES_VERSION # CAPZ config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants