-
Notifications
You must be signed in to change notification settings - Fork 2.7k
VPA: enable InPlaceOrRecreate feature gate in tests #34790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Max Cao <macao@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maxcao13 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @raywainman @omerap12 @adrianmoisey There's no way to test this config before shipping it right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/lgtm
hmmm I'm actually not sure about that.. but I see other projects that do the same thing so I guess it's ok - for example test-infra/config/jobs/kubernetes-sigs/azurefile-csi-driver/azurefile-csi-driver-config.yaml Lines 164 to 172 in 81fe97e
|
Enables the
InPlaceOrRecreate
feature gate by default in all periodic and pre-submit VPA tests.