-
Notifications
You must be signed in to change notification settings - Fork 2.7k
add test scripts and periodic prow job for testing two steps upgrade #34791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ynfx8
commented
May 13, 2025
- add test scripts to perform two steps upgrade - binary version upgrade and emulated version upgrade.
- config a n-minus-1 prow job for the new test. plan to configure n-minus-2 when seeing n-minus-1 tests are stable.
Hi @ynfx8. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @BenTheElder |
/assign @siyuanfoundation |
/ok-to-test |
spec: | ||
containers: | ||
- image: gcr.io/k8s-staging-test-infra/krte:v20250422-9d0e6fd518-master | ||
imagePullPolicy: Always # pull latest image for canary testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop this, we're using a stable tag based on the $date-$commit-hash of test-infra so pulling it every time is pointless and slow (it's a large shared image with e2e tools)
if the other job has it, was should also drop this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing this image been used in the job everywhere. Do you mean we don't need the image filed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the imagePullPolicy: Always
, this says "every time you run this pod, resolve and pull the tag" but this tag isn't mutated so pulling it every time even if the image is already available on the host is a waste.
https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed imagePullPolicy from all jobs in compatibility-versions-e2e.yaml
experiment/compatibility-versions/e2e-k8s-compatibility-versions-with-two-steps.sh
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,419 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a lot of bash to review, can we summarize the changes from the file it was modified from?
(or create it in two commits, one to copy the original file, the second to make changes so the diff is reviewable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[either describing in the pull request discussion or doing the two commit approach would be great, describing inside the file won't make sense, it can only be a point-in-time comparison before they diverge further]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated
- the following 3 lines
EMULATED_VERSION_UPGRADE_SCRIPT="${EMULATED_VERSION_UPGRADE_SCRIPT:-${PWD}/../test-infra/experiment/compatibility-versions/emulated-version-upgrade.sh}"
echo "Upgrading cluster with ${EMULATED_VERSION_UPGRADE_SCRIPT}"
bash -x "${EMULATED_VERSION_UPGRADE_SCRIPT}" | tee "${ARTIFACTS}/emulated-upgrade-output.txt"
- rename upgrade_cluster_components to upgrade_cluster_components_binary_version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it might be easier to share the code instead? we now need to patch both of these and the scripts are getting fairly complicated.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ynfx8 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-test-infra-verify-lint |
…ps upgrade * add test scripts to perform two steps upgrade - binary version upgrade and emulated version upgrade. * config a n-minus-1 prow job for the new test.