Skip to content

Commit 9ad6443

Browse files
vishal210893semmet95
authored andcommitted
refactor: minor doc changes
Signed-off-by: Amit Singh <singhamitch@outlook.com>
1 parent c587503 commit 9ad6443

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

docs/contributor/code-contribute.md

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -537,8 +537,7 @@ kubevela/kubevela
537537
- `oam-dev/terraform-config-inspect`
538538
539539
3. When upgrading a downstream repo that depends on one you just merged and which is not tagged yet, temporarily reference the upstream commit:
540-
- `go get github.com/kubevela/pkg@<commit-sha>` (creates a pseudo-version) OR
541-
- Add a `replace` directive pointing to that commit, then remove it after a tag is cut.
540+
- `go get github.com/kubevela/pkg@<commit-sha>` (creates a pseudo-version)
542541
543542
4. Only AFTER all other repositories are merged upgrade `kubevela/kubevela`
544543
- Create the upgrade PR from a branch named `chore/upgrade-k8s-*` (e.g. `chore/upgrade-k8s-1.29-to-1.30`). This naming convention triggers the upgrade verification pipelines.
@@ -570,15 +569,12 @@ Use this template in each PR description:
570569
571570
```
572571
### Upgrade Checklist
573-
- [ ] Go version set to 1.xx in go.mod
574-
- [ ] CI workflows use actions/setup-go with 1.xx
575-
- [ ] Dockerfile base image updated
576-
- [ ] k8s.io/* deps bumped to v1.yy.z
572+
- [ ] Go version set to x.y.z in go.mod
573+
- [ ] CI workflows use actions/setup-go with the same version: x.y.z
574+
- [ ] Dockerfile base image updated (based on compatibility with the new Go version)
575+
- [ ] k8s.io/* dependencies bumped to va.b.c
577576
- [ ] controller-runtime compatible version used
577+
- [ ] All the tests running Kubevela on a Kubernetes cluster (Kind/K3D) use the correct Kubernetes version
578578
- [ ] go mod tidy run cleanly
579579
- [ ] Generated code & CRDs regenerated
580-
- [ ] Unit tests pass
581-
- [ ] (If applicable) E2E / integration tests pass
582-
- [ ] Lint passes (golangci-lint)
583-
- [ ] Docs updated (README / contribution / install)
584580
```

0 commit comments

Comments
 (0)