We have to check first user is present or not #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to check first if username is present or not.
kunaltyagi9
reviewed
Mar 20, 2024
| @@ -14,7 +14,12 @@ export const singupUser = async (request, response) => { | |||
| const hashedPassword = await bcrypt.hash(request.body.password, 10); | |||
|
|
|||
| const user = { username: request.body.username, name: request.body.name, password: hashedPassword } | |||
|
|
|||
| //we need to first check if user already present or not if present then we have to throw an error otherwise we have | |||
There was a problem hiding this comment.
We should move these lines above the password hashing step because if the username already exists, there's no benefit in hashing the password if we're not going to save the user details in the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to check the username is present or not then and then we have to create new entry in our database