Skip to content

Commit 6ae593c

Browse files
committed
verify query param length before adding them to the cache key
1 parent 8337f16 commit 6ae593c

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

src/apicache.js

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -420,18 +420,24 @@ function ApiCache() {
420420
key = url.parse(key).pathname
421421
}
422422

423-
// Remove blacklisted query params
423+
// Remove blacklisted query params
424424
if (opt.queryParamsBlacklist.length > 0) {
425425
var queryParams = querystring.parse(url.parse(key).query)
426-
var validQueryParams = Object.keys(queryParams)
427-
.filter(function (key) {
428-
return globalOptions.queryParamsBlacklist.indexOf(key) === -1
429-
})
430-
.reduce(function (acc, header) {
431-
acc[header] = queryParams[header]
432-
return acc
433-
}, {})
434-
key = url.parse(key).pathname + '?' + querystring.stringify(validQueryParams)
426+
if (Object.keys(queryParams).length > 0) {
427+
var validQueryParams = Object.keys(queryParams)
428+
.filter(function(key) {
429+
return globalOptions.queryParamsBlacklist.indexOf(key) === -1
430+
})
431+
.reduce(function(acc, header) {
432+
acc[header] = queryParams[header]
433+
return acc
434+
}, {})
435+
436+
key = url.parse(key).pathname
437+
if (Object.keys(validQueryParams).length > 0) {
438+
key += '?' + querystring.stringify(validQueryParams)
439+
}
440+
}
435441
}
436442

437443
// add appendKey (either custom function or response path)

0 commit comments

Comments
 (0)