Skip to content

Commit 992a834

Browse files
committed
verify query param length before adding them to the cache key
1 parent 7f21bb3 commit 992a834

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

src/apicache.js

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -395,18 +395,24 @@ function ApiCache() {
395395
key = url.parse(key).pathname
396396
}
397397

398-
// Remove blacklisted query params
398+
// Remove blacklisted query params
399399
if (opt.queryParamsBlacklist.length > 0) {
400400
var queryParams = querystring.parse(url.parse(key).query)
401-
var validQueryParams = Object.keys(queryParams)
402-
.filter(function (key) {
403-
return globalOptions.queryParamsBlacklist.indexOf(key) === -1
404-
})
405-
.reduce(function (acc, header) {
406-
acc[header] = queryParams[header]
407-
return acc
408-
}, {})
409-
key = url.parse(key).pathname + '?' + querystring.stringify(validQueryParams)
401+
if (Object.keys(queryParams).length > 0) {
402+
var validQueryParams = Object.keys(queryParams)
403+
.filter(function(key) {
404+
return globalOptions.queryParamsBlacklist.indexOf(key) === -1
405+
})
406+
.reduce(function(acc, header) {
407+
acc[header] = queryParams[header]
408+
return acc
409+
}, {})
410+
411+
key = url.parse(key).pathname
412+
if (Object.keys(validQueryParams).length > 0) {
413+
key += '?' + querystring.stringify(validQueryParams)
414+
}
415+
}
410416
}
411417

412418
// add appendKey (either custom function or response path)

0 commit comments

Comments
 (0)