Skip to content

Fix headers option usage #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix headers option usage #198

wants to merge 1 commit into from

Conversation

arthurfranca
Copy link

@arthurfranca arthurfranca commented Mar 9, 2020 •
edited
Loading

fix #197 and fix #164

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.554% when pulling fe8c9c1 on arthurfranca:headers-option into f27cb2b on kwhitley:master.

@arthurfranca
Copy link
Author

Tests on old Node versions seems to be failing because of mocha lib.
Reverting mocha to v6.2.2 makes test pass on Node v6.2.0

@arthurfranca
Copy link
Author

Closed in favor of PR #205

@arthurfranca arthurfranca deleted the headers-option branch April 9, 2020 15:43
@leeyyl leeyyl mentioned this pull request Jun 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header option bugs Headers cannot be overwritten when cached response is served
2 participants
@arthurfranca @coveralls