-
Notifications
You must be signed in to change notification settings - Fork 71
Developed React Front End with Authentication Per User #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, absolutely, I quickly went though the code and these are good changes. I was thinking to create the users table and then I thought that maybe developers want to choose between different databases, but I guess it is good to create that table, least as an example. |
I've made quite a few changes to localize all environment settings into one file, so different deployments can be easily configured and tested. My latest is this branch: https://github.com/jcummins54/serverless-authentication-boilerplate/tree/react-authenticate Changes include:
Happy to get your feedback. |
@jcummins54 Nice, I'll check this later today, could you open a PR? I took a quick look to changes and those would be great additions. |
Sure, but take a look at line 19 on the authorizeHandler.js It's set up to parse a method arn structured specifically like this: I was thinking it would be a good idea to templatize this somehow so it can be configured in the env.yml instead of editing the code. |
Is there any plan to collapse these two repositories into a single code base? Even without the react part but just the other enhancements. The other thing I'm wondering, my use case is a bit different, I don't want to authenticate users to access API endpoints but I want to do the authentication to fetch the access_token to access the APIs. As example, getting the access_token from the google authentication so I can access the google apis. Thanks! |
I've forked the latest version of the master branch as of today (11/02/2016) and integrated with the serverless-react-boilerplate. Features are:
Working demo here: http://sls-react-auth.s3-website-us-east-1.amazonaws.com/ (facebook login only).
See: https://github.com/jcummins54/serverless-react-boilerplate
and https://github.com/jcummins54/serverless-authentication-boilerplate
Would be happy to collaborate to make this a branch here.
The text was updated successfully, but these errors were encountered: