Skip to content

Commit 2c4bcda

Browse files
Renamed method names
1 parent 0139d87 commit 2c4bcda

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

src/commercetools/testing/abstract.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ def delete_by_key(self, request, key):
283283
return create_commercetools_response(request, status_code=404)
284284

285285
def delete_by_container_and_key(self, request, container, key):
286-
obj = self.model.get_by_container_key(container, key)
286+
obj = self.model.get_by_container_and_key(container, key)
287287
if obj:
288288
if self._verify_version:
289289
response = self._validate_resource_version(request, obj)

src/commercetools/testing/custom_objects.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def add(self, draft, id=None):
2626
version matches. otherwise create a new item
2727
"""
2828
new_obj = self._create_from_draft(draft, id)
29-
current_obj = self._get_by_container_key(new_obj.container, new_obj.key)
29+
current_obj = self._get_by_container_and_key(new_obj.container, new_obj.key)
3030

3131
if current_obj:
3232
if current_obj["version"] != new_obj.version:
@@ -54,7 +54,7 @@ def _create_from_draft(
5454
last_modified_at=datetime.datetime.now(datetime.timezone.utc),
5555
)
5656

57-
def _get_by_container_key(
57+
def _get_by_container_and_key(
5858
self, container: str, key: str
5959
) -> typing.Optional[typing.Dict]:
6060
return next(
@@ -77,11 +77,15 @@ def urls(self):
7777
return [
7878
("^$", "GET", self.query),
7979
("^$", "POST", self.create),
80-
("^(?P<container>[^/]+)/(?P<key>[^/]+)$", "GET", self.get_by_container_key),
80+
(
81+
"^(?P<container>[^/]+)/(?P<key>[^/]+)$",
82+
"GET",
83+
self.get_by_container_and_key,
84+
),
8185
(
8286
"^(?P<container>[^/]+)/(?P<key>[^/]+)$",
8387
"POST",
84-
self.update_by_container_key,
88+
self.update_by_container_and_key,
8589
),
8690
(
8791
"^(?P<container>[^/]+)/(?P<key>[^/]+)$",
@@ -100,19 +104,19 @@ def query_by_container(self, request, container: str):
100104

101105
return self.query(request)
102106

103-
def get_by_container_key(self, request, container: str, key: str):
104-
item = self.model._get_by_container_key(container, key)
107+
def get_by_container_and_key(self, request, container: str, key: str):
108+
item = self.model._get_by_container_and_key(container, key)
105109
if item:
106110
return create_commercetools_response(request, json=item)
107111

108112
return create_commercetools_response(request, status_code=404)
109113

110-
def update_by_container_key(self, request, container: str, key: str):
111-
item = self.model._get_by_container_key(container, key)
114+
def update_by_container_and_key(self, request, container: str, key: str):
115+
item = self.model._get_by_container_and_key(container, key)
112116
return self._update(request, item)
113117

114118
def delete_by_container_and_key(self, request, container: str, key: str):
115-
item = self.model._get_by_container_key(container, key)
119+
item = self.model._get_by_container_and_key(container, key)
116120
if item:
117121
obj = self.model.delete_by_container_and_key(container, key)
118122
return create_commercetools_response(request, json=obj)

0 commit comments

Comments
 (0)