Skip to content

Commit bf4481b

Browse files
fixed delete test
1 parent 2c4bcda commit bf4481b

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/commercetools/testing/abstract.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ def delete_by_key(self, key):
119119
return self.objects.pop(obj_id)
120120

121121
def delete_by_container_and_key(self, container, key):
122-
for obj in self.objects.values():
122+
for obj_id, obj in self.objects.items():
123123
if obj["container"] == container and obj["key"] == key:
124-
return obj
124+
return self.objects.pop(obj_id)
125125

126126
def save(self, obj):
127127
assert obj["id"]

tests/platform/test_service_custom_objects.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,13 @@ def test_delete_by_container_and_key(old_client):
9595
)
9696
assert custom_object.id
9797
assert custom_object.key == "test-object-1"
98-
assert old_client.custom_objects.delete_by_container_and_key(
98+
deleted_object = old_client.custom_objects.delete_by_container_and_key(
9999
container=custom_object.container, key=custom_object.key
100100
)
101+
102+
assert deleted_object.key == "test-object-1"
103+
104+
with pytest.raises(HTTPError):
105+
old_client.custom_objects.delete_by_container_and_key(
106+
container=custom_object.container, key=custom_object.key
107+
)

0 commit comments

Comments
 (0)