Merge pull request #588 from labd/585-too-many-update-actions---should-batch-requests

fix: added chunking options for product_type resource update

Author: demeyerthom

.changes/unreleased/Fixed-20250509-154616.yaml

@@ -0,0 +1,3 @@
+kind: Fixed
+body: Added chunking option for product type updates
+time: 2025-05-09T15:46:16.943248527+02:00

commercetools/resource_product_type.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry"
 	"reflect"
+	"slices"
 	"strings"
 	"time"
 
@@ -367,29 +368,26 @@ func flattenProductTypeAttributeType(attrType platform.AttributeType, setsAllowe
 func resourceProductTypeUpdate(ctx context.Context, d *schema.ResourceData, m any) diag.Diagnostics {
 	client := getClient(m)
 
-	input := platform.ProductTypeUpdate{
-		Version: d.Get("version").(int),
-		Actions: []platform.ProductTypeUpdateAction{},
-	}
+	var actions []platform.ProductTypeUpdateAction
 
 	if d.HasChange("key") {
 		newKey := d.Get("key").(string)
-		input.Actions = append(
-			input.Actions,
+		actions = append(
+			actions,
 			&platform.ProductTypeSetKeyAction{Key: &newKey})
 	}
 
 	if d.HasChange("name") {
 		newName := d.Get("name").(string)
-		input.Actions = append(
-			input.Actions,
+		actions = append(
+			actions,
 			&platform.ProductTypeChangeNameAction{Name: newName})
 	}
 
 	if d.HasChange("description") {
 		newDescription := d.Get("description").(string)
-		input.Actions = append(
-			input.Actions,
+		actions = append(
+			actions,
 			&platform.ProductTypeChangeDescriptionAction{Description: newDescription})
 	}
 
@@ -400,13 +398,24 @@ func resourceProductTypeUpdate(ctx context.Context, d *schema.ResourceData, m an
 		if err != nil {
 			return diag.FromErr(err)
 		}
-		input.Actions = append(input.Actions, attrChangeActions...)
+		actions = append(actions, attrChangeActions...)
 	}
 
 	err := retry.RetryContext(ctx, 20*time.Second, func() *retry.RetryError {
-		_, err := client.ProductTypes().WithId(d.Id()).Post(input).Execute(ctx)
-		return utils.ProcessRemoteError(err)
+		var version = d.Get("version").(int)
+		for chunkedActions := range slices.Chunk(actions, 500) {
+			response, err := client.ProductTypes().WithId(d.Id()).Post(
+				platform.ProductTypeUpdate{Version: version, Actions: chunkedActions},
+			).Execute(ctx)
+			if err != nil {
+				return utils.ProcessRemoteError(err)
+			}
+			version = response.Version
+		}
+
+		return nil
 	})
+
 	if err != nil {
 		// Workaround invalid state to be written, see
 		// https://github.com/hashicorp/terraform-plugin-sdk/issues/476

commercetools/resource_product_type_test.go

@@ -722,6 +722,52 @@ func TestAccProductTypes_EnumValues(t *testing.T) {
 	})
 }
 
+func TestAccProductTypes_sliced(t *testing.T) {
+	t.Skip("Skipping test for large number of attributes")
+
+	key := "acctest-producttype"
+	identifier := "acctest_producttype"
+	resourceName := "commercetools_product_type.acctest_producttype"
+
+	var attributes []TestProductTypeAttrData
+	for i := 0; i < 1000; i++ {
+		attributes = append(attributes, TestProductTypeAttrData{
+			Name: fmt.Sprintf("%d", i),
+			Type: "text",
+		})
+	}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviders,
+		CheckDestroy:      testAccCheckProductTypesDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccConfigAttributes(key, identifier, []TestProductTypeAttrData{}),
+				Check: func(s *terraform.State) error {
+					r, err := testGetProductType(s, resourceName)
+					if err != nil {
+						return err
+					}
+					assert.EqualValues(t, *r.Key, key)
+					return nil
+				},
+			},
+			{
+				Config: testAccConfigAttributes(key, identifier, attributes),
+				Check: func(s *terraform.State) error {
+					r, err := testGetProductType(s, resourceName)
+					if err != nil {
+						return err
+					}
+					assert.EqualValues(t, *r.Key, key)
+					return nil
+				},
+			},
+		},
+	})
+}
+
 func testAccProductTypeConfigLabelChange(identifier, key string) string {
 	return hclTemplate(`
 		resource "commercetools_product_type" "{{ .identifier }}" {