style(FR-1696): touch up Folder explorer headisplay and display count #4581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
style/minor-touch-up
branch
from
11e930d to
6dbd272
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.68% | 547/11676 |
| 🔴 | Branches | 3.81% | 314/8231 |
| 🔴 | Functions | 2.91% | 104/3577 |
| 🔴 | Lines | 4.63% | 529/11417 |
Test suite run success
125 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from bfd10d6
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds font weight normalization and character count display to the folder name editor in the FolderExplorerHeader component.
- Reset font weight to 'normal' for the title section and input field to override BAIModal header styling
- Added character counter to the folder name input with a maximum of 64 characters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yomybaby
requested review from
agatha197,
ironAiken2 and
nowgnuesLee
and removed request for
nowgnuesLee
agatha197
requested changes
Nov 18, 2025
Contributor
agatha197
left a comment
agatha197
left a comment
There was a problem hiding this comment.
Can you modify EditableVFolderName too?
yomybaby
changed the title
Merge activity
|
…#4581) Resolves #4666 ([FR-1696](https://lablup.atlassian.net/browse/FR-1696)) # Reset font weight in FolderExplorerHeader and add character count to input This PR makes two styling changes to the FolderExplorerHeader component: 1. Resets the font weight to 'normal' in the title area to override the font weight set by BAIModal header 2. Adds a character counter to the input field with a maximum of 64 characters 3. Sets the input field's font weight to 'normal' These changes ensure consistent styling and provide better user feedback when entering text in the folder explorer. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1696]: https://lablup.atlassian.net/browse/FR-1696?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
style/minor-touch-up
branch
from
6dbd272 to
bfd10d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4666 (FR-1696)
Reset font weight in FolderExplorerHeader and add character count to input
This PR makes two styling changes to the FolderExplorerHeader component:
These changes ensure consistent styling and provide better user feedback when entering text in the folder explorer.
Checklist: