Skip to content

Conversation

@ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Nov 6, 2025

Implement File Browser Launcher in Folder Explorer

resolves #3791 (FR-1093)

This PR replaces the previous file browser execution method with a new implementation that:

  1. Fetches images that support file browser functionality
  2. Creates a session with the appropriate image (using system SSH image if configured)
  3. Mounts the current folder to the session
  4. Shows loading state during the process
  5. Displays error messages when no compatible images are found
  6. Modify ResourceAllocationFormValue to allow optional for shmem, accelerator, acceleratorType.

The implementation uses the useStartSession hook to launch a session with minimum required resources and the selected folder mounted.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

ironAiken2 commented Nov 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.62% (-0.01% 🔻)
530/11468
🔴 Branches
3.74% (-0.02% 🔻)
302/8080
🔴 Functions
2.88% (-0% 🔻)
102/3538
🔴 Lines
4.57% (-0.01% 🔻)
512/11213

Test suite run success

121 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 5d2a259

@ironAiken2 ironAiken2 marked this pull request as ready for review November 6, 2025 06:50
@ironAiken2 ironAiken2 force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from c347d9a to 838f284 Compare November 6, 2025 07:07
@ironAiken2 ironAiken2 requested a review from yomybaby November 6, 2025 07:17
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because architecture is empty, I failed to start file browser session. And I didn't get any error message.

backend.manager.errors.api.InvalidAPIParameters: Missing or invalid API parameters. (Input validation error)\n -> extra_data: {'lang': 'blank value is not allowed', 'architecture': 'blank value is not allowed'}\n"
}

@yomybaby yomybaby changed the base branch from refactor/FR-1653-extract-session-creation-hook to graphite-base/4596 November 6, 2025 07:45
Copy link
Contributor Author

Because architecture is empty, I failed to start file browser session. And I didn't get any error message.

backend.manager.errors.api.InvalidAPIParameters: Missing or invalid API parameters. (Input validation error)\n -> extra_data: {'lang': 'blank value is not allowed', 'architecture': 'blank value is not allowed'}\n"
}

This occurs when allowManualImageNameForSession and systemSSHImage are configured in config.toml. I modified the logic that passes systemSSHImage as a manual image and implemented error handling by processing the rejected state of the promise within a conditional statement.

@ironAiken2 ironAiken2 requested a review from agatha197 November 6, 2025 08:24
@ironAiken2 ironAiken2 force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 838f284 to 261be3b Compare November 6, 2025 08:33
@ironAiken2 ironAiken2 changed the base branch from graphite-base/4596 to main November 6, 2025 08:33
@ironAiken2 ironAiken2 changed the base branch from main to graphite-base/4596 November 7, 2025 04:16
@ironAiken2 ironAiken2 force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 261be3b to 873cfd3 Compare November 7, 2025 04:16
@ironAiken2 ironAiken2 changed the base branch from graphite-base/4596 to feautre/migrate-to-all-import-feature-to-react November 7, 2025 04:16
@ironAiken2 ironAiken2 requested a review from yomybaby November 7, 2025 04:34
Copy link
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the feautre/migrate-to-all-import-feature-to-react branch from d6ecc7a to 83b6f17 Compare November 10, 2025 01:45
@yomybaby yomybaby force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from b933e32 to 0dd9b8c Compare November 10, 2025 01:45
@ironAiken2 ironAiken2 force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 0dd9b8c to 5d2a259 Compare November 10, 2025 05:47
@graphite-app graphite-app bot changed the base branch from feautre/migrate-to-all-import-feature-to-react to graphite-base/4596 November 10, 2025 11:43
@yomybaby yomybaby force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 5d2a259 to 6b7cef3 Compare November 11, 2025 02:16
@yomybaby yomybaby changed the base branch from graphite-base/4596 to main November 11, 2025 02:16
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with #4612

@yomybaby yomybaby dismissed agatha197’s stale review November 11, 2025 07:56

It's already resolved.

@graphite-app
Copy link

graphite-app bot commented Nov 11, 2025

Merge activity

### Implement File Browser Launcher in Folder Explorer

resolves #3791 ([FR-1093](https://lablup.atlassian.net/browse/FR-1093))

This PR replaces the previous file browser execution method with a new implementation that:

1. Fetches images that support file browser functionality
2. Creates a session with the appropriate image (using system SSH image if configured)
3. Mounts the current folder to the session
4. Shows loading state during the process
5. Displays error messages when no compatible images are found
6. Modify `ResourceAllocationFormValue` to allow optional for `shmem, accelerator, acceleratorType`.

The implementation uses the `useStartSession` hook to launch a session with minimum required resources and the selected folder mounted.

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

[FR-1093]: https://lablup.atlassian.net/browse/FR-1093?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app bot force-pushed the feat/FR-1093-migrate-file-browser-function-to-react branch from 6b7cef3 to 2bd9044 Compare November 11, 2025 07:57
@graphite-app graphite-app bot merged commit 2bd9044 into main Nov 11, 2025
10 of 11 checks passed
@graphite-app graphite-app bot deleted the feat/FR-1093-migrate-file-browser-function-to-react branch November 11, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate filebrowser caller function to react.

5 participants