-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1093): migrate file browser function to react #4596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-1093): migrate file browser function to react #4596
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.62% (-0.01% 🔻) |
530/11468 |
| 🔴 | Branches | 3.74% (-0.02% 🔻) |
302/8080 |
| 🔴 | Functions | 2.88% (-0% 🔻) |
102/3538 |
| 🔴 | Lines | 4.57% (-0.01% 🔻) |
512/11213 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 5d2a259
c347d9a to
838f284
Compare
agatha197
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because architecture is empty, I failed to start file browser session. And I didn't get any error message.
backend.manager.errors.api.InvalidAPIParameters: Missing or invalid API parameters. (Input validation error)\n -> extra_data: {'lang': 'blank value is not allowed', 'architecture': 'blank value is not allowed'}\n"
}
This occurs when |
601fe05 to
4c28ccd
Compare
838f284 to
261be3b
Compare
261be3b to
873cfd3
Compare
nowgnuesLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
873cfd3 to
b933e32
Compare
d6ecc7a to
83b6f17
Compare
b933e32 to
0dd9b8c
Compare
0dd9b8c to
5d2a259
Compare
83b6f17 to
53cfb56
Compare
5d2a259 to
6b7cef3
Compare
yomybaby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with #4612
Merge activity
|
### Implement File Browser Launcher in Folder Explorer resolves #3791 ([FR-1093](https://lablup.atlassian.net/browse/FR-1093)) This PR replaces the previous file browser execution method with a new implementation that: 1. Fetches images that support file browser functionality 2. Creates a session with the appropriate image (using system SSH image if configured) 3. Mounts the current folder to the session 4. Shows loading state during the process 5. Displays error messages when no compatible images are found 6. Modify `ResourceAllocationFormValue` to allow optional for `shmem, accelerator, acceleratorType`. The implementation uses the `useStartSession` hook to launch a session with minimum required resources and the selected folder mounted. **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1093]: https://lablup.atlassian.net/browse/FR-1093?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
6b7cef3 to
2bd9044
Compare

Implement File Browser Launcher in Folder Explorer
resolves #3791 (FR-1093)
This PR replaces the previous file browser execution method with a new implementation that:
ResourceAllocationFormValueto allow optional forshmem, accelerator, acceleratorType.The implementation uses the
useStartSessionhook to launch a session with minimum required resources and the selected folder mounted.Checklist: (if applicable)