feat(FR-1662): use checkbox for openToPublic option in model service form
#4606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapsealk
requested review from
Copilot and
yomybaby
and removed request for
Copilot
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.67% (-0.02% 🔻) |
531/11377 |
| 🔴 | Branches | 3.77% (-0.05% 🔻) |
302/8016 |
| 🔴 | Functions | 2.89% (-0.01% 🔻) |
102/3526 |
| 🔴 | Lines | 4.61% (-0.03% 🔻) |
513/11120 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ImportNotebook.tsx |
0% | 100% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / graphql-transformer.ts |
82.26% (-4.92% 🔻) |
79.41% (-5.2% 🔻) |
71.43% (-3.57% 🔻) |
83.61% (-4.71% 🔻) |
| 🔴 | helper/index.tsx | 42.93% (-2.23% 🔻) |
40.12% (-0.73% 🔻) |
26.53% (-1.13% 🔻) |
43.5% (-2.01% 🔻) |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 9ee45d1
nowgnuesLee
requested changes
Nov 14, 2025
Co-authored-by: Seungwon Lee <seungwon@lablup.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Switch component with a Checkbox component for the "Open to Public" option in the model service launcher form, improving the UI/UX for this form field.
Key Changes
- Replaced
SwitchwithCheckboxcomponent in the service launcher form - Updated imports to include
Checkboxand removeSwitchfrom antd imports - Moved the label text from the Form.Item
labelprop to become children of the Checkbox component
nowgnuesLee
requested changes
Nov 14, 2025
Contributor
nowgnuesLee
left a comment
nowgnuesLee
left a comment
There was a problem hiding this comment.
could you apply the copilot review? i think it makes sense.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4605 (FR-1662)
This pull request updates the UI component for the "Open to Public" option on the
ServiceLauncherPageContentform. The main change is replacing theSwitchcomponent with aCheckbox, and updating the logic to handle its state within the form.UI Component Changes:
Switchcomponent with aCheckboxfor the "Open to Public" field, updating the import and usage inServiceLauncherPageContent.tsx. [1] [2]getFieldValueandsetFieldValue.Checklist: (if applicable)