feat(FR-1666): clamp CPU live stats to the theoretical maximum rage #4648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.68% | 547/11676 |
| 🔴 | Branches | 3.82% | 314/8227 |
| 🔴 | Functions | 2.91% | 104/3577 |
| 🔴 | Lines | 4.63% | 529/11417 |
Test suite run success
125 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 1b47b77
graphite-app
bot
changed the base branch from
feat/add-more-agent-stat-types
to
graphite-base/4648
yomybaby
force-pushed
the
graphite-base/4648
branch
from
20490a0 to
bfd10d6
Compare
yomybaby
force-pushed
the
feat/clamp-cpu-live-stats
branch
from
d013e0b to
5d92a85
Compare
Merge activity
|
…4648) resolves #4614 (FR-1666) This PR fixes CPU utilization calculation in several components: 1. In `AgentList.tsx`, updated the CPU utilization ratio calculation to use the percentage value directly from the node data and properly handle division by zero. 2. In `SessionSlotCell.tsx`, improved the CPU usage display by: - Using more descriptive variable names - Adding proper bounds checking with `Math.min` - Ensuring the percentage calculation is correctly capped at 100% 3. In `SessionUsageMonitor.tsx`, applied similar improvements to ensure CPU utilization is properly calculated and displayed, with appropriate upper bounds. **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
bot
force-pushed
the
feat/clamp-cpu-live-stats
branch
from
5d92a85 to
1b47b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4614 (FR-1666)
This PR fixes CPU utilization calculation in several components:
In
AgentList.tsx, updated the CPU utilization ratio calculation to use the percentage value directly from the node data and properly handle division by zero.In
SessionSlotCell.tsx, improved the CPU usage display by:Math.minIn
SessionUsageMonitor.tsx, applied similar improvements to ensure CPU utilization is properly calculated and displayed, with appropriate upper bounds.Checklist: (if applicable)