Skip to content

cairo1-run: honor relocate_mem and trace_enabled when relocating #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

cairo1-run: honor relocate_mem and trace_enabled when relocating #2241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
112d52c
cairo1-run: honor relocate_mem and trace_enabled when relocating
sashass1315 Oct 23, 2025
e0b17b7
add changelog
sashass1315 Oct 23, 2025
f6f2b49
Update CHANGELOG.md
sashass1315 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: honor relocate_mem and trace_enabled flags on cairo1-run [#2241](https://github.com/lambdaclass/cairo-vm/pull/2241)
Copy link
Collaborator

@gabrielbosio gabrielbosio Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the term 'honor' here might sound a bit confusing:

Suggested change
* fix: honor relocate_mem and trace_enabled flags on cairo1-run [#2241](https://github.com/lambdaclass/cairo-vm/pull/2241)
* fix: Make cairo1-run to conditionally relocate memory and trace [#2241](https://github.com/lambdaclass/cairo-vm/pull/2241)


* chore: Remove dead SegmentInfo struct from cairo_runner.rs [#2235](https://github.com/lambdaclass/cairo-vm/pull/2235)

* fix: Remove unused dependency getrandom for cairo1-run, and serde_json for wasm-demo-cairo1 [#2238](https://github.com/lambdaclass/cairo-vm/pull/2238)
Expand Down
2 changes: 1 addition & 1 deletion cairo1-run/src/cairo_run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ pub fn cairo_run_program(
}
}

runner.relocate(true, true)?;
runner.relocate(cairo_run_config.relocate_mem, cairo_run_config.trace_enabled)?;

Ok((runner, return_values, serialized_output))
}
Expand Down
Loading