Skip to content

Remove duplicate get_integer_from_var_name tests from memcpy_hint_utils #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 14, 2025
Merged

Remove duplicate get_integer_from_var_name tests from memcpy_hint_utils #2250

merged 7 commits into from
Nov 14, 2025
+0 −60

Conversation

@Galoretka
Copy link
Contributor

@Galoretka Galoretka commented Oct 27, 2025

Description

  • Removed misplaced duplicate tests in vm/src/hint_processor/builtin_hint_processor/memcpy_hint_utils.rs that asserted get_integer_from_var_name() behavior.
  • These tests belong to hint_utils.rs and already exist there; keeping duplicates is redundant.
  • Functions in memcpy_hint_utils.rs remain covered by existing tests in builtin_hint_processor_definition.rs and utils.rs

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@JulianGCalderon JulianGCalderon added the tests Implementation of tests label Nov 14, 2025
JulianGCalderon
JulianGCalderon requested changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Galoretka, thanks for the contribution!

Please restore the changelog, as this is test-only PR.

@Galoretka
Copy link
Contributor Author

Galoretka commented Nov 14, 2025

Hey @Galoretka, thanks for the contribution!

Please restore the changelog, as this is test-only PR.

Ok, did it

JulianGCalderon
JulianGCalderon approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielbosio gabrielbosio added this pull request to the merge queue Nov 14, 2025
Merged via the queue into lambdaclass:main with commit f6339d8 Nov 14, 2025
89 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielbosio gabrielbosio gabrielbosio approved these changes

@JulianGCalderon JulianGCalderon JulianGCalderon approved these changes

Assignees

No one assigned

Labels

tests Implementation of tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Galoretka @gabrielbosio @JulianGCalderon