Skip to content

fix(l1, l2): make levm default in enum#2632

Merged
jrchatruc merged 9 commits intomainfrom
levm-default
May 12, 2025
Merged

fix(l1, l2): make levm default in enum#2632
jrchatruc merged 9 commits intomainfrom
levm-default

Conversation

@mpaulucci
Copy link
Copy Markdown
Collaborator

Motivation
Just set the default vm in a single place

Description

  • Even though the cli changed to levm, we still had revm as the default enum

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 28, 2025

Lines of code report

Total lines added: 9
Total lines removed: 24
Total lines changed: 33

Detailed view
+-------------------------------------+-------+------+
| File                                | Lines | Diff |
+-------------------------------------+-------+------+
| ethrex/crates/networking/rpc/rpc.rs | 623   | -24  |
+-------------------------------------+-------+------+
| ethrex/crates/vm/backends/mod.rs    | 244   | +9   |
+-------------------------------------+-------+------+

@mpaulucci mpaulucci marked this pull request as ready for review May 8, 2025 18:00
@mpaulucci mpaulucci requested a review from a team as a code owner May 8, 2025 18:00
assert_eq!(response.to_string(), expected_response.to_string());
}

#[tokio::test]
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing since this test is outdated and is a copy of the one with have in hive

@jrchatruc jrchatruc added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 18f113b May 12, 2025
29 checks passed
@jrchatruc jrchatruc deleted the levm-default branch May 12, 2025 19:13
fmoletta pushed a commit that referenced this pull request May 15, 2025
**Motivation**
Just set the default vm in a single place

**Description**
- Even though the cli changed to `levm`, we still had `revm` as the
default enum

---------

Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
pedrobergamini pushed a commit to pedrobergamini/ethrex that referenced this pull request Aug 24, 2025
**Motivation**
Just set the default vm in a single place

**Description**
- Even though the cli changed to `levm`, we still had `revm` as the
default enum

---------

Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants