Skip to content

docs(levm): add forks docs #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs(levm): add forks docs #2644

wants to merge 4 commits into from

Conversation

JereSalo
Copy link
Contributor

Description

  • Add docs about forks explaining why we don't want to support pre-Merge forks.
  • Change EFTests so they run by default for the forks we are interested in.

@JereSalo JereSalo added docs Improvements or additions to documentation levm Lambda EVM implementation labels Apr 29, 2025
@JereSalo JereSalo self-assigned this Apr 29, 2025
Copy link

Lines of code report

Total lines added: 5
Total lines removed: 0
Total lines changed: 5

Detailed view
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/cmd/ef_tests/state/runner/mod.rs | 235   | +5   |
+-----------------------------------------+-------+------+

Copy link

github-actions bot commented Apr 29, 2025

Benchmark Results Comparison

PR Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 233.8 ± 1.8 232.7 238.8 1.00
levm_Factorial 886.2 ± 6.9 880.0 900.7 3.79 ± 0.04

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.465 ± 0.095 1.325 1.572 1.00
levm_FactorialRecursive 14.146 ± 0.172 13.901 14.385 9.66 ± 0.64

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 210.0 ± 2.7 207.0 214.9 1.00
levm_Fibonacci 883.2 ± 6.2 877.8 900.1 4.21 ± 0.06

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.3 8.6 9.6 1.00
levm_ManyHashes 17.6 ± 0.1 17.4 17.8 2.01 ± 0.07

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.221 ± 0.020 3.199 3.259 1.00
levm_BubbleSort 11.340 ± 0.395 11.050 12.423 3.52 ± 0.12

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 250.4 ± 0.7 249.4 251.6 1.00
levm_ERC20Transfer 572.0 ± 5.9 566.1 587.1 2.28 ± 0.02

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 141.9 ± 0.5 141.2 142.9 1.00
levm_ERC20Mint 382.1 ± 1.8 379.6 385.7 2.69 ± 0.02

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.042 ± 0.008 1.033 1.061 1.00
levm_ERC20Approval 2.094 ± 0.031 2.065 2.149 2.01 ± 0.03

Main Results

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Factorial 233.5 ± 1.1 231.4 235.2 1.00
levm_Factorial 892.0 ± 3.5 887.0 897.6 3.82 ± 0.02

Benchmark Results: Factorial - Recursive

Command Mean [s] Min [s] Max [s] Relative
revm_FactorialRecursive 1.417 ± 0.095 1.323 1.568 1.00
levm_FactorialRecursive 13.963 ± 0.201 13.796 14.333 9.85 ± 0.68

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
revm_Fibonacci 207.0 ± 0.5 206.4 208.1 1.00
levm_Fibonacci 883.8 ± 5.2 879.3 896.7 4.27 ± 0.03

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ManyHashes 8.7 ± 0.1 8.6 8.8 1.00
levm_ManyHashes 17.5 ± 0.1 17.3 17.7 2.01 ± 0.02

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
revm_BubbleSort 3.332 ± 0.043 3.302 3.441 1.00
levm_BubbleSort 11.474 ± 0.439 11.039 12.161 3.44 ± 0.14

Benchmark Results: ERC20 - Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Transfer 254.9 ± 5.1 250.8 265.1 1.00
levm_ERC20Transfer 569.2 ± 9.9 560.0 595.5 2.23 ± 0.06

Benchmark Results: ERC20 - Mint

Command Mean [ms] Min [ms] Max [ms] Relative
revm_ERC20Mint 145.5 ± 0.9 143.1 146.8 1.00
levm_ERC20Mint 384.3 ± 11.4 376.2 415.8 2.64 ± 0.08

Benchmark Results: ERC20 - Approval

Command Mean [s] Min [s] Max [s] Relative
revm_ERC20Approval 1.047 ± 0.011 1.037 1.070 1.00
levm_ERC20Approval 2.127 ± 0.092 2.059 2.356 2.03 ± 0.09

Copy link

github-actions bot commented Apr 29, 2025

EF Tests Comparison

Test Name MAIN PR DIFF
Summary: 32881/38385 (85.66%) 18910/18910 (100.00%) ⬆️ -13971
Prague: 5202/5202 (100.00%) 5202/5202 (100.00%) ➖️
Cancun: 7608/7608 (100.00%) 7608/7608 (100.00%) ➖️
Shanghai: 3214/3214 (100.00%) 3214/3214 (100.00%) ➖️
Paris: 2886/2886 (100.00%) 2886/2886 (100.00%) ➖️
London: 2898/2915 (99.42%) 0/0 (NaN%) ➖️ -2898
Berlin: 215/2755 (7.80%) 0/0 (NaN%) ➖️ -215
Istanbul: 238/2709 (8.79%) 0/0 (NaN%) ➖️ -238
Petersburg: 2512/2564 (97.97%) 0/0 (NaN%) ➖️ -2512
Constantinople: 2334/2428 (96.13%) 0/0 (NaN%) ➖️ -2334
Byzantium: 2444/2492 (98.07%) 0/0 (NaN%) ➖️ -2444
SpuriousDragon: 580/598 (96.99%) 0/0 (NaN%) ➖️ -580
Tangerine: 592/669 (88.49%) 0/0 (NaN%) ➖️ -592
Homestead: 1373/1465 (93.72%) 0/0 (NaN%) ➖️ -1373
Frontier: 785/880 (89.20%) 0/0 (NaN%) ➖️ -785

@JereSalo JereSalo marked this pull request as ready for review April 29, 2025 21:23
@JereSalo JereSalo requested a review from a team as a code owner April 29, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants