Skip to content

fix(l2): bench crate #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 5, 2025
Merged

fix(l2): bench crate #2647

merged 6 commits into from
May 5, 2025

Conversation

xqft
Copy link
Contributor

@xqft xqft commented Apr 29, 2025

The pipeline was failing because of:

  1. some breaking changes (renamed imports)
  2. a previously existing bug that we didn't catch until perf(core): transform the inline variant of NodeHash to a const sized array #2516 (we were encoding a leaf node without its leaf flag, so it would be decoded into an extension leaf and produce a panic)
  3. we were executing the prover in L2 mode because we depended on ethrex-l2 (and in ethrex-prover, which depends on ethrex-l2), and that crate enables the L2 feature of ethrex-vm by default.
    • The solution was to make an l2 feature for ethrex-l2, which isn't ideal. A better (but bigger) solution is proposed in L2: provers refactor #2662

@xqft xqft requested a review from a team as a code owner April 29, 2025 21:36
Copy link

github-actions bot commented Apr 29, 2025

Lines of code report

Total lines added: 0
Total lines removed: 1
Total lines changed: 1

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/l2/prover/bench/src/main.rs | 95    | -1   |
+-------------------------------------------+-------+------+

@xqft xqft mentioned this pull request May 2, 2025
@xqft xqft merged commit 3271f9f into l2/bump_sp1 May 5, 2025
25 checks passed
@xqft xqft deleted the l2/fix_bench_2 branch May 5, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants